HADOOP-19252. Upgrade hadoop-thirdparty to 1.3.0 #7007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Aug 20, 2024
|
@slfan1989 not going to merge this until we've done the vote. looking at why the shade failed too |
steveloughran
force-pushed
the
build/HADOOP-19252-thirdparty-1.3.0
branch
from
482d623 to
0d4044c
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
@steveloughran Thank you for advancing the release of Hadoop 3.4.1! I will validate the Hadoop-thirdparty 1.3.0 version and participate in the voting. |
pan3793
reviewed
Aug 21, 2024
LICENSE-binary
Outdated
| commons-collections:commons-collections:3.2.2 | ||
| commons-daemon:commons-daemon:1.0.13 | ||
| commons-io:commons-io:2.16.1 | ||
| commons-net:commons-net:3.9.0 | ||
| de.ruedigermoeller:fst:2.50 | ||
| io.grpc:grpc-api:1.53.0 | ||
| io.grpc:grpc-api:1.53.0AA |
|
docker is failing to move to the new version as the build process for the new protoc native binaries require bazel. going to revert the docker changes |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
steveloughran
force-pushed
the
build/HADOOP-19252-thirdparty-1.3.0
branch
from
96d0d06 to
9c7c1a3
Compare
|
(!) A patch to the testing environment has been detected. |
Update the version of hadoop-thirdparty to 1.3.0 across all shaded artifacts used. This synchronizes the shaded protobuf library with those of all other shaded artifacts (guava, avro) Change-Id: Ia4875f24ec8d75e362cadf52c049583b8f49e9bb
steveloughran
force-pushed
the
build/HADOOP-19252-thirdparty-1.3.0
branch
from
9c7c1a3 to
2848939
Compare
LICENSE-binary
Outdated
| @@ -485,7 +486,7 @@ com.microsoft.sqlserver:mssql-jdbc:6.2.1.jre7 | |||
| org.bouncycastle:bcpkix-jdk18on:1.78.1 | |||
| org.bouncycastle:bcprov-jdk18on:1.78.1 | |||
| org.bouncycastle:bcutil-jdk18on:1.78.1 | |||
| org.checkerframework:checker-qual:2.5.2 | |||
| org.checkerframework:checker-qual:jar:3.8.0 | |||
There was a problem hiding this comment.
do we need the word "jar" here?
There was a problem hiding this comment.
no, i was just lining up things from mvn dependency scan. will cut
LICENSE-binary
Outdated
| com.google.json-simple:json-simple:1.1.1 | ||
| com.google.guava:failureaccess:1.0 | ||
| com.google.guava:guava:20.0 | ||
| com.google.guava:guava:27.0-jre | ||
| com.google.guava:guava:jar:32.0.1-jre |
There was a problem hiding this comment.
do we need the word "jar" here?
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Change-Id: I720d84163509d747530b71851c42d302c81925b7
pan3793
reviewed
Aug 29, 2024
| @@ -298,6 +298,7 @@ javax.inject:javax.inject:1 | |||
| net.java.dev.jna:jna:5.2.0 | |||
| net.minidev:accessors-smart:1.2 | |||
| org.apache.avro:avro:1.9.2 | |||
| org.apache.avro:avro:1.11.3 | |||
There was a problem hiding this comment.
no, actually. There's an unshaded avro in there too related to the AvroFileFormat
./share/hadoop/common/lib/avro-1.9.2.jar
./share/hadoop/hdfs/lib/avro-1.9.2.jar
I'd like it cut, but for now: it is there
There was a problem hiding this comment.
alright, thanks for the information
|
💔 -1 overall
This message was automatically generated. |
|
not happy that so many hdfs tests are OOM. It's not just this PR though, so merging |
steveloughran
added a commit
that referenced
this pull request
Sep 5, 2024
…7014) Update the version of hadoop-thirdparty to 1.3.0 across all shaded artifacts used. This synchronizes the shaded protobuf library with those of all other shaded artifacts (guava, avro) Note: this patch moves from 1.2.0; the trunk PR moves from 1.3.0-SNAPSHOT and is slightly different Contributed by Steve Loughran
asfgit
pushed a commit
that referenced
this pull request
Sep 5, 2024
…7014) Update the version of hadoop-thirdparty to 1.3.0 across all shaded artifacts used. This synchronizes the shaded protobuf library with those of all other shaded artifacts (guava, avro) Note: this patch moves from 1.2.0; the trunk PR moves from 1.3.0-SNAPSHOT and is slightly different Contributed by Steve Loughran
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Sep 9, 2024
Update the version of hadoop-thirdparty to 1.3.0 across all shaded artifacts used. This synchronizes the shaded protobuf library with those of all other shaded artifacts (guava, avro) Contributed by Steve Loughran
Hexiaoqiao
pushed a commit
to Hexiaoqiao/hadoop
that referenced
this pull request
Sep 12, 2024
Update the version of hadoop-thirdparty to 1.3.0 across all shaded artifacts used. This synchronizes the shaded protobuf library with those of all other shaded artifacts (guava, avro) Contributed by Steve Loughran
DremioQA
pushed a commit
to dremio/hadoop
that referenced
this pull request
Apr 17, 2025
) (apache#7014) Update the version of hadoop-thirdparty to 1.3.0 across all shaded artifacts used. This synchronizes the shaded protobuf library with those of all other shaded artifacts (guava, avro) Note: this patch moves from 1.2.0; the trunk PR moves from 1.3.0-SNAPSHOT and is slightly different Contributed by Steve Loughran Change-Id: I5fabfb145c461152941c5d00c7c935e4e1a28c4d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the version of hadoop-thirdparty to 1.3.0
across all shaded artifacts used.
This synchronizes the shaded protobuf library with those of all other shaded artifacts (guava, avro)
Updated LICENSE-binary to include the shaded versions
Notes
I'll create a JIRA for this but focus on 3.4 release first
How was this patch tested?
did a local rebuild with profile asf-snapshot
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?