Skip to content

Tests and handling for all Pytorch versions >=2.0.0 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
apoorvkh opened this issue Jul 5, 2024 · 1 comment · Fixed by #53
Closed

Tests and handling for all Pytorch versions >=2.0.0 #31

apoorvkh opened this issue Jul 5, 2024 · 1 comment · Fixed by #53

Comments

@apoorvkh
Copy link
Owner

apoorvkh commented Jul 5, 2024

I think the Pytorch distributed API changed somewhere after 2.0.0, so our code probably doesn't work for all versions right now
@apoorvkh
Copy link
Owner Author

I think we can use tox for this, should run the simple CI test on all PyTorch versions

@pmcurtin pmcurtin linked a pull request Jul 25, 2024 that will close this issue
handle older PyTorch versions #53
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle older PyTorch versions apoorvkh/torchrunx
1 participant
@apoorvkh