-
Notifications
You must be signed in to change notification settings - Fork 1
handle older PyTorch versions #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I worked out that in version 2.3 they changed the arguments to |
Ok, so with this change I've additionally tested PyTorch versions 2.0.0, 2.1.0, 2.2.0, 2.4.0. I think our dev environment is 2.3.0. So that covers everything >=2.0.0, I think? I don't think minor versions like 2.2.1 would fail if 2.3.0 works? |
That's great -- the only thing I would add is that we should use a tool like |
Yeah I'll look into doing it automatically with tox. |
Maybe use Github actions to do the matrix And Pixi "features" to specify different PyTorch and Python versions https://pixi.sh/latest/features/multi_environment/#feature-environment-set-definitions |
debugging failing tests
disable fast-fail
[draft] this will have to wait until the new logging is merged with main, since some of the CI tests fail?
📚 Documentation preview 📚: https://torchrunx--53.org.readthedocs.build/en/53/