Skip to content

This package no longer builds in release mode on linux #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
finagolfin opened this issue Jul 30, 2022 · 2 comments · Fixed by #481
Closed
2 tasks done

This package no longer builds in release mode on linux #463

finagolfin opened this issue Jul 30, 2022 · 2 comments · Fixed by #481

Comments

@finagolfin
Copy link
Contributor

Building in release mode produces this since #410 was merged:

> ./swift-5.6.2-RELEASE-ubuntu20.04/usr/bin/swift build -c release
/home/butta/swift-argument-parser/Sources/ArgumentParserTestHelpers/TestHelpers.swift:12:18: error: module 'ArgumentParser' was not compiled for testing
@testable import ArgumentParser

That means the last working version was 1.0.3. A workaround is to add -Xswiftc -enable-testing.

ArgumentParser version: latest commit df9ee66 from the main branch
Swift version: 5.5 and later, probably earlier versions too

Checklist

  • If possible, I've reproduced the issue using the main branch of this package
  • I've searched for existing GitHub issues
@finagolfin finagolfin mentioned this issue Jul 30, 2022
Closed
natecook1000 added a commit to natecook1000/swift-argument-parser that referenced this issue Aug 31, 2022
@natecook1000
Declare Hashable conformance for ArgumentVisibility
82f1abf 
In addition to being useful, this allows us to drop the `@testable`
annotation for the ArgumentParser import in ArgumentParserTestHelpers,
which resolves apple#463.
@natecook1000 natecook1000 mentioned this issue Aug 31, 2022
Merged
4 tasks
natecook1000 added a commit that referenced this issue Sep 1, 2022
@natecook1000
Declare Hashable conformance for ArgumentVisibility (#481)
d7aa440 
In addition to being useful, this allows us to drop the `@testable`
annotation for the ArgumentParser import in ArgumentParserTestHelpers,
which resolves #463.
@natecook1000
Copy link
Member

@buttaface Could you verify that this issue is resolved with the latest version of main?

@finagolfin
Copy link
Contributor Author

Yep, works now, thanks. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Declare Hashable conformance for ArgumentVisibility natecook1000/swift-argument-parser
2 participants
@natecook1000 @finagolfin