Skip to content

Declare Hashable conformance for ArgumentVisibility #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

natecook1000
Copy link
Member

In addition to being useful, this allows us to drop the @testable annotation for the ArgumentParser import in ArgumentParserTestHelpers, which resolves #463.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

In addition to being useful, this allows us to drop the `@testable`
annotation for the ArgumentParser import in ArgumentParserTestHelpers,
which resolves apple#463.
@natecook1000
Copy link
Member Author

@swift-ci Please test

@rauhul
Copy link
Contributor

rauhul commented Aug 31, 2022

Just so I understand ArgumentVisibility: Hashable is orthogonal to changing the tests to not switch over .base, correct?

@natecook1000
Copy link
Member Author

Right, it's generally useful if the library declaring types like this includes hashability, since clients shouldn't add this kind of conformance.

@natecook1000 natecook1000 merged commit d7aa440 into apple:main Sep 1, 2022
@natecook1000 natecook1000 deleted the hashable-help-viz branch September 1, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This package no longer builds in release mode on linux
2 participants