Merged
Conversation
Add ability to provide add_copy_py_file_to_sandbox_py_module_command and similar functions with modules containing '.' (e.g. appleseed.studio)
est77
requested changes
Aug 2, 2017
Member
est77
left a comment
est77
left a comment
There was a problem hiding this comment.
Thanks for improving our python packaging cmake macros.
I'd prefer not to add the extra appleseed directory inside appleseed.python.
Other than that, I have some small comments and it'd good to merge for me.
| { | ||
| } | ||
|
|
||
| PythonInterpreter::~PythonInterpreter() |
Member
There was a problem hiding this comment.
Can we leave the destructor, comment Py_Finalize() and add a comment to explain why we don't call it?
| # | ||
|
|
||
| from _appleseedstudio import * | ||
| import Qt |
Member
There was a problem hiding this comment.
We should remove this line. Using any python Qt binding should be optional and if the user does not have one,
we should not error.
glebmish
force-pushed
the
python-modules-improvements
branch
from
b6771c5 to
66fe751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored of appleseed.python/CMakeLists.txt to update build process of Python bindings
Added Qt.py - library that wraps different Qt Python binding (PyQt, PySide and so on) and provides unified interface for them