Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/appleseed.studio/mainwindow/mainwindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -321,10 +321,9 @@ QDockWidget* MainWindow::create_dock_widget(const char* dock_name)
dock_widget->setObjectName(object_name);
dock_widget->setWindowTitle(dock_name);


const QList<QAction*>& actions = m_ui->menu_view->actions();
const auto& actions = m_ui->menu_view->actions();
QAction* menu_separator = actions.last();
for (size_t i = (size_t) actions.size() - 2; i != 0; --i)
for (size_t i = static_cast<size_t>(actions.size()) - 2; i != 0; --i)
if (actions[i]->isSeparator())
{
menu_separator = actions[i];
Expand Down
1 change: 1 addition & 0 deletions src/appleseed.studio/python/module.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
// appleseed.foundation headers.
#include "foundation/core/exceptions/exception.h"
#include "foundation/platform/python.h"
#include "foundation/utility/casts.h"

// Qt headers.
#include <QDockWidget>
Expand Down
5 changes: 0 additions & 5 deletions src/appleseed.studio/python/pythoninterpreter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,5 @@ PythonInterpreter::PythonInterpreter()
{
}

PythonInterpreter::~PythonInterpreter()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave the destructor, comment Py_Finalize() and add a comment to explain why we don't call it?

{
Py_Finalize();
}

} // namespace studio
} // namespace appleseed
1 change: 0 additions & 1 deletion src/appleseed.studio/python/pythoninterpreter.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ class PythonInterpreter

private:
PythonInterpreter();
~PythonInterpreter();

void import_python_module(const char* module_name, const char* alias_name);

Expand Down