Skip to content

update to adj assertions, remove _rev concept #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 21, 2024
Merged

update to adj assertions, remove _rev concept #37

merged 11 commits into from
Aug 21, 2024

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Aug 20, 2024 •
edited
Loading

Also includes #39

@aMahanna aMahanna changed the title initial commit update to adj assertion Aug 20, 2024
@aMahanna aMahanna marked this pull request as draft August 20, 2024 15:57
@aMahanna aMahanna marked this pull request as ready for review August 20, 2024 16:41
hkernbach
hkernbach reviewed Aug 20, 2024
View reviewed changes
@aMahanna
new: _rev assertions, newDict assertions
f79cf86 
this is currently failing on the `_rev` assertions for digraph & graph
@aMahanna
Merge branch 'update-assert' of https://github.com/arangodb/nx-arangodb…
4bec931 
… into update-assert
@aMahanna aMahanna mentioned this pull request Aug 20, 2024
Merged
@aMahanna
Copy link
Member Author

@hkernbach I've opened #39, which is ready for review. It branches off from this PR, and proposes to remove _rev as a concept entirely

aMahanna and others added 2 commits August 21, 2024 12:26
@aMahanna
Merge branch 'main' into update-assert
f28b523
@aMahanna
Remove _rev concept (#39)
51de668 
* initial commit | remove `_rev` logic

* remove: `root` concept

* cleanup: `del "_rev"`

* fix: lint

* cleanup test

* fix: return clause
@aMahanna aMahanna changed the title update to adj assertion update to adj assertions, remove _rev concept Aug 21, 2024
@aMahanna aMahanna requested a review from hkernbach August 21, 2024 17:31
@aMahanna aMahanna merged commit 5fcc0f4 into main Aug 21, 2024
4 checks passed
@aMahanna aMahanna deleted the update-assert branch August 21, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkernbach hkernbach hkernbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aMahanna @hkernbach