Remove _rev concept
#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aMahanna
commented
Aug 21, 2024
aMahanna
added a commit
that referenced
this pull request
Aug 21, 2024
* initial commit * attempt: try to cache the update data * cleanup * update assertions * new: _rev assertions, `newDict` assertions this is currently failing on the `_rev` assertions for digraph & graph * Remove `_rev` concept (#39) * initial commit | remove `_rev` logic * remove: `root` concept * cleanup: `del "_rev"` * fix: lint * cleanup test * fix: return clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched off of #37
This PR proposes to remove the concept of
_revfrom NetworkX Nodes & Edges.It became a headache to maintain after CRUD operations, especially around the
update()methods we're introducing.The current solution to this is to manually delete the
_revfields whenever possible.Perhaps we can adjust the
phenolrscomponent as a future improvement to optionally omit_revfrom retrieved data to make things easier on memory