fix: safeguard nosql container disposal #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for arcus-testing canceled.
|
stijnmoreels
commented
Nov 1, 2024
Collaborator
🧪 Code coverage summary
Great job! 😎 Your code coverage is higher than my caffeine levels! ☕ |
ClementVaillantCodit
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just came to my attention that we best use
WaitUntil.Completedinstead ofWaitUntil.Startedso that even if people incorrectly use the fixture or not isolate their test enough and multiple calls gets made towards the same container name, we always know that after the dispose, the container gets deleted (if necessary).This decreases performance a bit, but pays back in a more stable fixtures in instable environments.