fix: safeguard nosql container disposal

src/Arcus.Testing.Storage.Cosmos/TemporaryNoSqlContainer.cs

@@ -86,7 +86,7 @@ public static NoSqlItemFilter PartitionKeyEqual(PartitionKey partitionKey)
         /// <summary>
         /// Creates a filter to match a NoSql item based on its contents.
         /// </summary>
-        /// <typeparam name="TItem">The custom custom type </typeparam>
+        /// <typeparam name="TItem">The custom type </typeparam>
         /// <param name="itemFilter">The custom filter to match against the contents of the NoSql item.</param>
         /// <exception cref="ArgumentNullException">Thrown when the <paramref name="itemFilter"/> is <c>null</c>.</exception>
         /// <exception cref="InvalidOperationException">Thrown when the used client has no serializer configured.</exception>
@@ -202,8 +202,8 @@ public class OnTeardownNoSqlContainerOptions
         internal OnTeardownNoSqlContainer Items { get; private set; }
 
         /// <summary>
-        /// (default for cleaning documents) Configures the <see cref="TemporaryNoSqlContainer"/> to only delete the NoSql items upon disposal
-        /// if the document was inserted by the test fixture (using <see cref="TemporaryNoSqlContainer.AddItemAsync{TItem}"/>).
+        /// (default for cleaning items) Configures the <see cref="TemporaryNoSqlContainer"/> to only delete the NoSql items upon disposal
+        /// if the item was inserted by the test fixture (using <see cref="TemporaryNoSqlContainer.AddItemAsync{TItem}"/>).
         /// </summary>
         public OnTeardownNoSqlContainerOptions CleanCreatedItems()
         {
@@ -225,7 +225,7 @@ public OnTeardownNoSqlContainerOptions CleanAllItems()
         /// upon disposal that match any of the configured <paramref name="filters"/>.
         /// </summary>
         /// <remarks>
-        ///     The matching of documents only happens on NoSql items that were created outside the scope of the test fixture.
+        ///     The matching of items only happens on NoSql items that were created outside the scope of the test fixture.
         ///     All items created by the test fixture will be deleted upon disposal, regardless of the filters.
         ///     This follows the 'clean environment' principle where the test fixture should clean up after itself and not linger around any state it created.
         /// </remarks>
@@ -572,7 +572,7 @@ public async ValueTask DisposeAsync()
                 disposables.Add(AsyncDisposable.Create(async () =>
                 {
                     _logger.LogDebug("[Test:Teardown] Delete Azure Cosmos NoSql '{ContainerName}' container in database '{DatabaseName}'", _container.Id.Name, _container.Id.Parent?.Name);
-                    await _container.DeleteAsync(WaitUntil.Started);
+                    await _container.DeleteAsync(WaitUntil.Completed);
                 })); 
             }
             else

src/Arcus.Testing.Tests.Integration/Arcus.Testing.Tests.Integration.csproj

@@ -25,6 +25,7 @@
     <ProjectReference Include="..\Arcus.Testing.Assert\Arcus.Testing.Assert.csproj" />
     <ProjectReference Include="..\Arcus.Testing.Core\Arcus.Testing.Core.csproj" />
     <ProjectReference Include="..\Arcus.Testing.Integration.DataFactory\Arcus.Testing.Integration.DataFactory.csproj" />
+    <ProjectReference Include="..\Arcus.Testing.Logging.Xunit\Arcus.Testing.Logging.Xunit.csproj" />
     <ProjectReference Include="..\Arcus.Testing.Storage.Blob\Arcus.Testing.Storage.Blob.csproj" />
     <ProjectReference Include="..\Arcus.Testing.Storage.Cosmos\Arcus.Testing.Storage.Cosmos.csproj" />
     <ProjectReference Include="..\Arcus.Testing.Storage.Table\Arcus.Testing.Storage.Table.csproj" />

src/Arcus.Testing.Tests.Integration/IntegrationTest.cs

@@ -1,5 +1,4 @@
-using Arcus.Template.Tests.Integration.Logging;
-using Arcus.Testing.Tests.Integration.Configuration;
+using Arcus.Testing.Tests.Integration.Configuration;
 using Bogus;
 using Microsoft.Extensions.Logging;
 using Xunit.Abstractions;

src/Arcus.Testing.Tests.Integration/Storage/Fixture/NoSqlTestContext.cs

@@ -163,12 +163,9 @@ public async Task ShouldStoreContainerAsync(string containerId)
         /// </summary>
         public async Task ShouldNotStoreContainerAsync(string containerId)
         {
-            await Poll.UntilAvailableAsync<XunitException>(async () =>
-            {
-                Container cont = Database.GetContainer(containerId);
-                var exception = await Assert.ThrowsAnyAsync<CosmosException>(() => cont.ReadContainerAsync());
-                Assert.Equal(HttpStatusCode.NotFound, exception.StatusCode);
-            });
+            Container cont = Database.GetContainer(containerId);
+            var exception = await Assert.ThrowsAnyAsync<CosmosException>(() => cont.ReadContainerAsync());
+            Assert.Equal(HttpStatusCode.NotFound, exception.StatusCode);
         }
 
         /// <summary>