Merge aspnet/WebHooks into this repository #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added details to update links
Add MS_WebHookStripeInTestMode to execute custom StripeWebHookHandlers for test events ('evt_00000000000000')
Add StripeEvent and StripeEventData classes
…t to conflict with System.Configuration.SettingsProvider.
… a Controller or ApiController, for example from an Azure WebJob. When used with WebJobs, this can be used for sending WebHooks as a result of a messages arriving for a WebJob triggered by an Azure queue, blog, table, Service Bus Queue, or any other source that can trigger a WebJob, see https://azure.microsoft.com/en-us/documentation/articles/websites-webjobs-resources/ for more details.
Updated readme with new blog links
Added link to CRM blog
…lack.com/slash-commands' We now provide support for more easily responding with structured text allowing you to fully take advantage of all Slash Command features including including images, tables, and a variety of properties including author, title, etc.
…ommands style of the format /command action value /command action p1=v1; p2=v2; ... An example of an outgoing WebHook or slash command using the first format is '/assistant query what's the weather?' where '/assistant' is the trigger word or slash command, 'query' is the action and 'what's the weather?' is the value. In the second form, parameter values containing semi-colons can either escape the semi-colon using a backslash character, i.e '\;', or quote the value using single quotes or double quotes. An example of an outgoing WebHook or slash command using this format is '/appointment add title=doctor visit; time=Feb 3 2016 2 PM; location=Children's Hospital' where '/appointment' is the trigger word or slash command, 'add' is the action and title, time, and location are parameters. This makes it much simpler to add support for Slack slash commands and outgoing webhook that take parameters from the user. Updated the SlackSample to illustrate use of this for both outgoing webhooks and slash commands.
…going through the WebHookRegistrationsController Web API controller allowing an IWebHookRegistrar implementation to change, modify, or reject WebHook registrations as they are created or updated. This can for example be used to add filters to registrations enabling broadcast notifications or specific group notifications. Filters added this way can either be publicly visible or private filters intended for server side processing only. In the former case, any filters added in an IWebHookRegistrar implementation must be listed by an IWebHookFilterManager implementation. In the latter case, the filter must be prefixed by the string "MS_Private_" to remain hidden from the user. Failure to do either of these will lead to WebHook registration updates being rejected due to unknown filters.
…es so that users don't *have* to use DI to change the default implementation. It of course still works *if* they want to use DI, not it is just not a hard requirement just to change where config settings come from.
…get called when a WebHook succeeds, is gone, or fails. This enables for a variety of post-send processing scenarios where an implementation may want to take certain actions depending on the result of a WebHook send.
…ot all instances come in through the ASP.NET Web API registration controller, we have to run validation explicitly to verify that we have a correct WebHook registration. To validate a WebHook instance, call IWebHookManager.VerifyWebHookAsync which will also verify that the registered WebHook URI is valid.
- Tag mandatory properties with Required.Always so JSON.NET enforces the requirement during (de)serialization - Fix a couple of comment typos on KuduNotification - Add required 'resourceRegion' property to AlertMessage1.json test content - Add AlertMessage3.json to validate change against sample payload in Azure docs - Add unit tests
…eans that geo- and tag-based subscriptions no longer work. Only user-based subscriptions which again mean that we must have an OAuth token in order to actually receive the media posted. Updated Instagram receiver sample to reflect this: It now supports oauth authentication for a user to log in and to consent an Instagram Application. Once that is done, it is possible to receive notifications,
- not necessary with Global Routing disabled This reverts commit fad82fd.
Disable Global Routing in all applications using WebHooks - use a merge commit to keep the very different pieces somewhat separate
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
…spnet/AspLabs repo This source code before this reorganization was originally found at https://github.com/aspnet/webhooks/tree/9887b4ecbc4a3a79902781c05c30020539a29e91
Eilon
approved these changes
Oct 10, 2018
mkArtakMSFT
reviewed
Oct 10, 2018
| @@ -9,11 +9,17 @@ | |||
| <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)eng\AspNetCore.snk</AssemblyOriginatorKeyFile> | |||
| <SignAssembly>true</SignAssembly> | |||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | |||
| <LangVersion>7.3</LangVersion> | |||
There was a problem hiding this comment.
The default is 7.0. KoreBuild overrides the default to 7.2, so I had to add this after removing KoreBuild stuff.
mkArtakMSFT
approved these changes
Oct 10, 2018
dougbu
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/aspnetcore#3598
This merges the history of https://github.com/aspnet/WebHooks into this repository. The only changes between this PR and latest commit on master of aspnet/WebHooks are: