This repository was archived by the owner on Dec 20, 2018. It is now read-only.
netcoreapp2.0 #228
Merged
netcoreapp2.0 #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichalla
approved these changes
May 4, 2017
| @@ -3,8 +3,7 @@ | |||
| <Import Project="..\..\build\common.props" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>netcoreapp2.0;net46</TargetFrameworks> | |||
| <TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp2.0</TargetFrameworks> | |||
| <TargetFramework>netcoreapp2.0</TargetFramework> | |||
| <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects> | |||
There was a problem hiding this comment.
you can remove the following 2 elements cc @pranavkm
There was a problem hiding this comment.
There seem to be other files with similar content.
pranavkm
suggested changes
May 5, 2017
| @@ -160,34 +160,7 @@ public override Task WriteAsync(byte[] buffer, int offset, int count, Cancellati | |||
| return _innerStream.WriteAsync(buffer, offset, count, cancellationToken); | |||
| } | |||
| } | |||
| #if NET46 | |||
| @@ -3,9 +3,7 @@ | |||
|
|
|||
| using System; | |||
| using System.Collections.ObjectModel; | |||
| #if NETSTANDARD1_3 | |||
| using System.Reflection; | |||
pranavkm
suggested changes
May 5, 2017
| @@ -137,58 +137,6 @@ public override void Write(byte[] buffer, int offset, int count) | |||
| } | |||
| } | |||
|
|
|||
| #if NET46 | |||
| @@ -108,36 +108,6 @@ public void Write_IsPassedToUnderlyingStream_WhenDisableResponseBuffering(bool f | |||
| Assert.Equal(File.ReadAllBytes(path), written); | |||
| } | |||
|
|
|||
| #if NET46 | |||
| @@ -570,16 +563,9 @@ public void Options_HttpsDisabledByDefault() | |||
|
|
|||
| var response = await client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead); | |||
|
|
|||
| #if NET46 // Flush not supported, compression disabled | |||
There was a problem hiding this comment.
Flush is supported on core
|
@pranavkm 🆙📅 |
pranavkm
approved these changes
May 5, 2017
mikeharder
approved these changes
May 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.