This repository was archived by the owner on Oct 18, 2018. It is now read-only.
restore override of Begin/EndRead #175
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidfowl is convinced we don't need these, so closing this :). Certainly all the tests pass both with and without this change and the code in question only runs in tests, so meh. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed these when I was making the
netcoreapp2.0changes, because they were#ifed out, but aspnet/BasicMiddleware#228 (comment) and aspnet/ResponseCaching#121 (comment) make me think that's wrong and these overrides should be present in thenetcoreapp2.0version.