This repository was archived by the owner on Nov 22, 2018. It is now read-only.
Migration #121
Merged
Migration #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
requested review from
analogrelay,
Eilon,
muratg,
Tratcher and
mikeharder
mikeharder
approved these changes
May 4, 2017
Eilon
approved these changes
May 4, 2017
analogrelay
suggested changes
May 5, 2017
| @@ -183,19 +183,12 @@ public override void WriteByte(byte value) | |||
| } | |||
| } | |||
|
|
|||
| #if NETSTANDARD1_3 | |||
| public IAsyncResult BeginWrite(byte[] buffer, int offset, int count, AsyncCallback callback, object state) | |||
There was a problem hiding this comment.
Is this right? Wouldn't you want this code and not the other one? This branch was the one used by the netstandard build (which was actually the only build anyway)
There was a problem hiding this comment.
Yes, we need to override Begin/End stream methods. These were not in early standards.
analogrelay
approved these changes
May 5, 2017
|
Merged to dev: f536c02 |
|
@JunTaoLuo: Please delete branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.