Skip to content
This repository was archived by the owner on Dec 8, 2018. It is now read-only.

DeveloperExceptionPage should include routing details #403

Closed
miloush opened this issue Aug 6, 2017 · 4 comments
Closed

DeveloperExceptionPage should include routing details #403

miloush opened this issue Aug 6, 2017 · 4 comments

Comments

@miloush
Copy link

miloush commented Aug 6, 2017

If applicable, the exception page should have a tab with current route name, controller, action and routing values.

@davidfowl
Copy link
Member

@rynowak is this feasible? Is the routing feature available on the outgoing or do we remove it from the request on the way out?

@Eilon Eilon added this to the 2.1.0 milestone Aug 7, 2017
@Eilon
Copy link
Contributor

Eilon commented Aug 7, 2017

There's also the minor problem of the Diagnostics page having access to the IRouteFeature (or whatever it's called). But if we move routing lower down the stack, that would just solve itself.

Regarding whether the routing feature is available on the outgoing, I wonder in general if it makes sense for middlesware to remove features on the way out? We've seen that sometimes cause issues in this type of error case.

@rynowak
Copy link
Member

rynowak commented Aug 7, 2017

Yes, this is feasible.

@aspnet-hello
Copy link

This issue was moved to dotnet/aspnetcore#2586

@aspnet aspnet locked and limited conversation to collaborators Jan 2, 2018
@aspnet-hello aspnet-hello removed this from the 2.1.0-preview1 milestone Jan 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants