Skip to content

Dedicated page for JavaScript invoked on server-side #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aspnet-hello opened this issue Jan 2, 2018 · 5 comments
Closed

Dedicated page for JavaScript invoked on server-side #2585

aspnet-hello opened this issue Jan 2, 2018 · 5 comments
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-diagnostics Diagnostic middleware and pages (except EF diagnostics) Needs: Design This issue requires design work before implementating.
Milestone
3.0.0-preview1

Comments

@aspnet-hello
Copy link

From @rosieks on Friday, August 18, 2017 1:24:13 PM

SpaServices project provides ability to run JavaScript on server. When such invocation failed the following error is displayed.

image

It would be nice to have dedicated page that focus on JavaScript error and provide nicefied stacktrace, current npm version, etc

Copied from original issue: aspnet/Diagnostics#404
@aspnet-hello aspnet-hello added this to the 2.1.0-preview1 milestone Jan 2, 2018
@aspnet-hello aspnet-hello added enhancement This issue represents an ask for new feature or an enhancement to an existing one Needs: Design This issue requires design work before implementating. repo:Diagnostics labels Jan 2, 2018
@aspnet-hello
Copy link
Author

From @Eilon on Wednesday, August 23, 2017 12:11:12 AM

@SteveSandersonMS any thoughts on this? We've been thinking of some diagnostics pages extensibility in general, for example: aspnet/Diagnostics#403

@aspnet-hello
Copy link
Author

From @SteveSandersonMS on Wednesday, August 23, 2017 12:02:31 PM

It would definitely be good to present this information more readably - the stack trace at least.

If the new diagnostics extensibility point issued a call back to get the nicely formatted error info, passing the original exception, then it would be easy enough to embed whatever info we need into the NodeInvocationException and pull it out.

@aspnet-hello
Copy link
Author

From @Eilon on Thursday, August 24, 2017 10:33:38 AM

Ok, we'll consider something for 2.1.0 then.

@aspnet-hello aspnet-hello mentioned this issue Jan 2, 2018
Closed
@mkArtakMSFT mkArtakMSFT modified the milestones: 2.1.0-preview2, 2.2.0 Mar 27, 2018
@Eilon Eilon modified the milestones: 2.2.0-preview1, 2.2.0 Oct 18, 2018
@mkArtakMSFT mkArtakMSFT modified the milestones: 2.2.0, 3.0.0 Nov 1, 2018
natemcmaster pushed a commit that referenced this issue Nov 15, 2018
@halter73
Re-enable ConnectionCountingReturnsToZero on non-macOS machines (#2585)
a13339d
@Eilon Eilon added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-diagnostics Diagnostic middleware and pages (except EF diagnostics) and removed repo:Diagnostics labels Nov 26, 2018
ryanbrandenburg pushed a commit that referenced this issue Nov 27, 2018
@mikaelm12
Merge pull request #2585 from aspnet/release/2.2
896c669 
Formatting urls when using the WebSocketsTransport (#2571)
@mkArtakMSFT
Copy link
Contributor

Hi. Thanks for contacting us.
We're closing this issue as there was no much community interest in this ask for quite a while now.

@ajaybhargavb ajaybhargavb mentioned this issue Jan 9, 2019
Closed
@cjblomqvist
Copy link

It seems this has not been fixed and will not be fixed? Or am I missing something? This would be very helpful. Atm this makes it very cumbersome to develop anything using NodeServices, since it's always guesswork to figure out where errors come from.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-diagnostics Diagnostic middleware and pages (except EF diagnostics) Needs: Design This issue requires design work before implementating.
Projects
None yet
Milestone
3.0.0-preview1
Development

No branches or pull requests
5 participants
@Eilon @cjblomqvist @amcasey @mkArtakMSFT @aspnet-hello