Skip to content

DeveloperExceptionPage should include routing details #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aspnet-hello opened this issue Jan 2, 2018 · 3 comments
Closed

DeveloperExceptionPage should include routing details #2586

aspnet-hello opened this issue Jan 2, 2018 · 3 comments
Assignees
@JamesNK
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-diagnostics Diagnostic middleware and pages (except EF diagnostics) Needs: Design This issue requires design work before implementating.
Milestone
3.0.0-preview2

Comments

@aspnet-hello
Copy link

From @miloush on Sunday, August 6, 2017 12:05:38 PM

If applicable, the exception page should have a tab with current route name, controller, action and routing values.

Copied from original issue: aspnet/Diagnostics#403
@aspnet-hello aspnet-hello added this to the 2.1.0-preview1 milestone Jan 2, 2018
@aspnet-hello aspnet-hello added 1 - Ready enhancement This issue represents an ask for new feature or an enhancement to an existing one Needs: Design This issue requires design work before implementating. labels Jan 2, 2018
@aspnet-hello
Copy link
Author

From @davidfowl on Sunday, August 6, 2017 11:00:20 PM

@rynowak is this feasible? Is the routing feature available on the outgoing or do we remove it from the request on the way out?

@aspnet-hello
Copy link
Author

From @Eilon on Monday, August 7, 2017 10:25:37 AM

There's also the minor problem of the Diagnostics page having access to the IRouteFeature (or whatever it's called). But if we move routing lower down the stack, that would just solve itself.

Regarding whether the routing feature is available on the outgoing, I wonder in general if it makes sense for middlesware to remove features on the way out? We've seen that sometimes cause issues in this type of error case.

@aspnet-hello
Copy link
Author

From @rynowak on Monday, August 7, 2017 11:28:55 AM

Yes, this is feasible.

@aspnet-hello aspnet-hello mentioned this issue Jan 2, 2018
Closed
@mkArtakMSFT mkArtakMSFT modified the milestones: 2.1.0-preview1, 2.2.0 Jan 17, 2018
@Eilon Eilon modified the milestones: 2.2.0-preview1, 2.2.0 Oct 18, 2018
@mkArtakMSFT mkArtakMSFT modified the milestones: 2.2.0, 3.0.0 Nov 1, 2018
natemcmaster pushed a commit that referenced this issue Nov 15, 2018
@mikeharder
Improve reliability of MaxRequestBufferSizeTests.LargeUpload (#2586)
1951ddf 
- Increase _dataLength from 20MB to 40MB to improve test reliability when using Sockets transport on Windows
- Addresses aspnet/KestrelHttpServer#2225
@Eilon Eilon added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-diagnostics Diagnostic middleware and pages (except EF diagnostics) and removed repo:Diagnostics labels Nov 26, 2018
@JamesNK JamesNK mentioned this issue Jan 3, 2019
Merged
@JamesNK JamesNK closed this as completed Jan 4, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesNK JamesNK

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-diagnostics Diagnostic middleware and pages (except EF diagnostics) Needs: Design This issue requires design work before implementating.
Projects
None yet
Milestone
3.0.0-preview2
Development

No branches or pull requests
5 participants
@Eilon @JamesNK @amcasey @mkArtakMSFT @aspnet-hello