This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Reorganize the strong header type extensions. Remove SendAsync extensions #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -23,12 +23,14 @@ public static ResponseHeaders GetTypedHeaders(this HttpResponse response) | |||
| return new ResponseHeaders(response.Headers); | |||
| } | |||
|
|
|||
| public static DateTimeOffset? GetDate([NotNull] this IHeaderDictionary headers, [NotNull] string name) | |||
| // These are all shared helpers used by both RequestHeaders and ResponseHeaders | |||
|
|
|||
|
RequestHeaders and ResponseHeaders seem to share some code. Would it make sense to create an abstract class that covers the shared functionality, and move the functionality in the HeaderDictionaryTypeExtensions (which are currently becoming Internal with this change) to this shared abstract class? |
|
I tried that in the initial feature work but it was rejected in code review. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#274
HeaderDictionaryTypeExtensions: "Remove everything except GetTypedHeaders. Everything else goes to public method on Either ReuqestHeaders or ResponseHeaders depending on who uses them"
HttpResponseSendingExtensions: "Cut all of these. If there is significant or painful to work around uses then come back to us."