This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Faster CopyFromAscii #1308
Closed
Faster CopyFromAscii #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shift8Idenitity should probably be Shift8Identity |
|
PRing a variant of this to coreclr dotnet/coreclr#8969 as then will effect all serialization (json, mvc etc) |
cesarblum
suggested changes
Jan 17, 2017
| @@ -1214,6 +1214,71 @@ public void TestGetAsciiStringEscaped(string input, string expected, int maxChar | |||
| } | |||
| } | |||
|
|
|||
| [Fact] | |||
| public unsafe void TestCopyFromAscii() | |||
There was a problem hiding this comment.
I'd like to see some boundary testing here, since you're copying 8 bytes at a time and then whatever is left.
| @@ -21,6 +21,9 @@ public struct MemoryPoolIterator | |||
| 0x02ul << 40 | | |||
| 0x01ul << 48 ) + 1; | |||
|
|
|||
| const int Shift16Shift24 = 256 * 256 * 256 + 256 * 256; | |||
| const int Shift8Idenitity = 256 + 1; | |||
There was a problem hiding this comment.
As pointed out my @mharthoorn, Shift8Identity.
benaadams
force-pushed
the
CopyFromAscii
branch
from
4853a98 to
177e7d9
Compare
|
Rebased + sp Need to add boundary testing |
|
Added large boundary test range; shared parsing between single and multi block; added 64/32 bit split and alignment processing. Probably need to rebench |
Copy ulong per loop, less variables, split multiblock into own path
benaadams
force-pushed
the
CopyFromAscii
branch
from
773b3f9 to
66f7549
Compare
|
Added benchmarks Before After |
benaadams
force-pushed
the
CopyFromAscii
branch
from
9388305 to
ed66e0e
Compare
benaadams
commented
Jan 23, 2017
| @@ -21,9 +21,6 @@ public struct MemoryPoolIterator | |||
| 0x02ul << 40 | | |||
| 0x01ul << 48 ) + 1; | |||
|
|
|||
| const int Shift16Shift24 = 256 * 256 * 256 + 256 * 256; | |||
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy
ulongper loop, less variable comparison, less variable changes, split multiblock into own pathBefore
After
Also added test for the function...