This repository was archived by the owner on Dec 18, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append() before 80 bytes, after 64 bytes zeroed AppendNonPrimaryHeaders() before 888 bytes, after 48 bytes zeroed
Reduces stack from 296 to 216 bytes Also drops one of the header scans (2 scans now rather than 3)
Copy ulong per loop, less variables, split multiblock into own path
… into for-davidfowl
@CesarBS found the benchmark start issue; if you include a src project in global.json; you also need to include it in the Performance global.json otherwise it compiles, rerestores, compiles and first test errors as compile hasn't written when it starts. Is a bit weird |
@benaadams Are you referring to #1314 (comment)? Problem is we don't have |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidfowl wanted some numbers
Following changes merged
Change #1318
Change #1313
Change #1308
Change #1301
Needs aspnet/HttpAbstractions#757 for the changes
And aspnet/Benchmarks#170 to use benchmarks repo with changes
Kestrel benchmark testing
Before
dotnet run -c Release RequestParsing
After
Before
dotnet run -c Release ResponseHeaders
After