This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Dispose of MemoryPool2; suppress its finalizers #343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
force-pushed
the
dispose-memorypool2
branch
6 times, most recently
from
164a9d7 to
44f0027
Compare
| @@ -9,21 +9,28 @@ | |||
|
|
|||
| namespace Microsoft.AspNet.Server.KestrelTests | |||
| { | |||
| class TestInput : IConnectionControl, IFrameControl | |||
There was a problem hiding this comment.
Doesn't this require change MessageBodyTests?
benaadams
force-pushed
the
dispose-memorypool2
branch
2 times, most recently
from
26a8b83 to
a90180a
Compare
benaadams
force-pushed
the
dispose-memorypool2
branch
from
a90180a to
ee4d9c3
Compare
|
This is probably better #402 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to unpin the MemoryPoolSlab2 buffers and SuppressFinalize on all the MemoryPoolBlock2 objects