This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Only use pooled buffers #402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,6 +74,9 @@ protected MemoryPoolBlock2() | |||
| /// </summary> | |||
| public MemoryPoolBlock2 Next { get; set; } | |||
|
|
|||
| #if DEBUG | |||
There was a problem hiding this comment.
Maybe we should have a Debug.Assert for when Slab != null to ensure that we are always returning the block (in our tests at least).
There was a problem hiding this comment.
Also probably shouldn't add blocks that aren't pooled to the pool in Return
There was a problem hiding this comment.
Removed non-pooled blocks instead (from Lease)
|
Have something better |
benaadams
changed the title
benaadams
force-pushed
the
block-finalizer
branch
from
8d2c888 to
c2c7adc
Compare
|
Revisit this later |
|
Needs some revitalization... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use pooled blocks.
Don't finalize blocks outside debug.
For the cost of just including a finalizer on allocation see:
http://www.philosophicalgeek.com/2014/09/29/digging-into-net-object-allocation-fundamentals/