This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Use pooled memory for Stream CopyToAsync #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
changed the title
benaadams
changed the title
benaadams
changed the title
| { | ||
| var returnedBlock = task.Result; | ||
| returnedBlock.Pool?.Return(returnedBlock); |
There was a problem hiding this comment.
If SocketInput asks for blocks larger than a pooled block; and then returns them to pool - had a related PR #402 to stop it; wasn't sure - too much churn at the time.
There was a problem hiding this comment.
In this case, since we aren't providing a minimum size to memory.Lease(), the pool should never be null.
There was a problem hiding this comment.
Weird; thought non-pooled blocks could get returned; but looks like that changed way back...
There was a problem hiding this comment.
Added PR #448 to address this; re-closed the only use pooled blocks PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default buffer size Is crazy large (82kB); and as is used for lifetime of connection; per connection - likely ends up in Gen2
(Ref https://github.com/dotnet/coreclr/issues/2223)