Bind to both IPv4 and IPv6 when localhost is specified (#231). #870
Conversation
|
|
||
| if (parsedAddress.Host.Equals("localhost", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| var exceptions = new List<Exception>(); |
There was a problem hiding this comment.
Creating and adding to a list just to get a count? Why not just use a counter?
There was a problem hiding this comment.
Yeah that was different before and I didn't revert this. I was throwing an AggregateException.
There was a problem hiding this comment.
Do you think that might be better?
|
Travis is producing a bunch of |
cesarblum
force-pushed
the
cesarbs/bind-localhost-to-ipv4-and-ipv6
branch
from
d6eadc9 to
a5e15f6
Compare
|
|
||
| // Make sure we bind to the same port on port 0. | ||
| var port = ipv4Address.Port; | ||
| var ipv6Address = parsedAddress.WithHost("[::1]").WithPort(port); |
|
No more filters. |
|
|
cesarblum
force-pushed
the
cesarbs/bind-localhost-to-ipv4-and-ipv6
branch
from
dbbda16 to
373d0ac
Compare
|
Updated to disallow binding to |
| } | ||
|
|
||
| // Make sure we bind to the same port on port 0. | ||
| var port = ipv4Address.Port; |
There was a problem hiding this comment.
You can remove this logic since we no longer support localhost:0.
cesarblum
force-pushed
the
cesarbs/bind-localhost-to-ipv4-and-ipv6
branch
2 times, most recently
from
85d9a33 to
6da59d5
Compare
|
🔔 |
| @@ -81,7 +81,6 @@ public void NoDelay(bool enable) | |||
| /// </summary> | |||
| public static IPEndPoint CreateIPEndpoint(ServerAddress address) | |||
| { | |||
| // TODO: IPv6 support | |||
There was a problem hiding this comment.
I would leave this comment in for now. I can remove it when I fix #766.
|
You can |
cesarblum
force-pushed
the
cesarbs/bind-localhost-to-ipv4-and-ipv6
branch
from
e033a33 to
a3d0bd0
Compare
#231
cc @halter73 @mikeharder @Tratcher