Add copy helpers for TagHelperOutput from TagBuilder. #1322

NTaylorMullen · 2014-10-10T01:07:58Z

Added a new test project for tag helper specific code.
Tested out Merge and MergeAttributes.
Tag Helpers: Add TagHelperOutput extension methods to copy from TagBuilder #1319

dougbu · 2014-10-10T01:21:42Z

src/Microsoft.AspNet.Mvc.TagHelpers/TagHelperOutputHelper.cs

+
+namespace Microsoft.AspNet.Mvc.TagHelpers
+{
+    internal class TagHelperOutputHelper


leave this public but move it into Microsoft.AspNet.Mvc.TagHelpers.Internals

dougbu · 2014-10-10T01:31:38Z

⌚

NTaylorMullen · 2014-10-10T05:41:48Z

Addressed code review comments. Will wait for rebase to pick up Mvc.sln fix. My VS is in ruins 😢

NTaylorMullen · 2014-10-10T06:09:15Z

test/Microsoft.Aspnet.Mvc.TagHelpers.Test/project.json

@@ -0,0 +1,17 @@
+{


Add to Mvc.NoFun.sln once the Microsoft.AspNet.Mvc.TagHelpers project is there.

…r.Service on test finish

This change includes the basic properties that we're providing for compatability as well as some functional tests and unit tests that verify that ApiController can be a controller class.

Adds an options class, as well as a default options setup that will configure the default set of formatters. Currently most of what options needs to do is a placeholder, but it later do things like add ApplicationModelConventions, filters, formatters, model binders, etc. Those will be added in follow up items.

This change adds ApplicationModel conventions that can enable WebAPI action conventions (verb mapping) and WebAPI overloading. The conventions activate when a controller has a marker attribute. ApiController has this attribute, so any ported code will automatically opt-in. Also ported some old tests for action selection to our new functional test framework.

This change adds a .Request property to the ApiController class that can be used to access an HttpRequestMessage wrapping the HttpContext. The HttpRequestMessage is stored in an http feature to make it accessible to model binders and other infrastructure.

This change adds a ModelBinder that can bind an HttpRequestMessage to an action parameter. This builds on an earlier change to construct and store the request message in the HttpContext via an http feature.

Adds a formatter that can convert an HttpResponseMessage returned from an action into HttpContext.Response output.

Adds the set of CreateResponse/CreateErrorResponse extension methods that return an HttpResponseMessage. For the overloads that perform content negotiation they will access the collection of MediaTypeFormatters through the shim options. Note that CreateResponse and friends use the OLD formatters. Also, HttpError and CreateErrorResponse assume ErrorDetail == false. Using the shim you will not get detailed error messages unless you construct the HttpError instance yourself.

dougbu · 2014-10-11T05:22:52Z

src/Microsoft.AspNet.Mvc.TagHelpers/TagHelperOutputHelper.cs

+                attribute.Key.StartsWith(prefix, StringComparison.OrdinalIgnoreCase)).ToArray();
+
+            // Since we're "pulling" the prefixed attribute values we need to remove the attributes that have the given
+            // prefix from our output.


nits:

"the attributes that have the given prefix" is (surprisingly) more confusing than "them"

comma before "we need"

dougbu · 2014-10-11T05:37:04Z

(all my comments are nits or less)

Fixes #1344

dougbu · 2014-10-13T18:50:17Z

please close this PR and open one based on TagHelpersFeature

Fixes #1302

1) Expose the simplified relative path template by cleaning up constraints, optional and catch all tokens from the template. 2) Expose the parameters on the route template as API parameters. 3) Combine parameters from the route and the action descriptor when the parameter doesn't come from the body. #886 will refine this. 4) Expose optionality and constraints for path parameters. Open question: Should we explicitly expose IsCatchAll?

Fixes #845

…pResponseMessageOutputFormatter

Ported from aspnet/dnx@36cd490 Fixes #1324

NTaylorMullen · 2014-10-14T17:48:09Z

Going to hold off on rebasing onto TagHelpersFeature until your textarea.tests PR is in. The other PR's in the chain starting with this PR point to taghelper.refactor.1243 which we forced to be a copy of your textarea.tests branch.

Fixes #1107

…data to Enum parameter. Fix: Using TypeConverter solves this problem. -Issue #1123 - TypeConverterModelBinder cannot bind "byte" and "short". Fix: Modified code to use TypeConverter which can handle these scenarios. -Removing the GetConverterDelegate method and making the code similar to the WebApi.

…ing, PathString, etc. To build Urls. Added tests to describe the current behaviour with Unicode hosts.

- part of #1243 (kind-of) - mostly copied from `HtmlHelper` but refactored to - consistently take a `ViewContext` parameter and return a `TagBuilder` - provide `GenerateActionLink()` and `GenerateRouteLink()` - provide a separate `GenerateHiddenForCheckBox()`, allowing `GenerateCheckBox()` to return a `TagBuilder` - `GenerateForm()`'s `method` parameter is a `string`, not `FormMethod` nits: format document, consistent line wrapping, variable name changes, ...

…ple.Web - also fix a couple of minor issues in TagHelperSample.Web

- rest of #1243 and all of #1244 - needs a few utility methods for copying `TagBuilder` to `TagHelperOutput` - but works as-is

- new Microsoft.AspNet.Mvc.TagHelpers.Test project - bit of test infrastructure -- `TestableHtmlGenerator` - short-curcuits validation attribute and AntiForgery additions - should help when testing all MVC tag helpers

- make a few more methods available as `internal static` in `DefaultHtmlGenerator` - remove `IHtmlGenerator.GenerateOption()`; now `internal static` nits: - add `IHtmlGenerator.IdAttributeDotReplacement` - move `DefaultHtmlGenerator.IdAttributeDotReplacement` after constructor - move `HtmlHelper.ActionLink()` below static methods - move newly-`internal` methods together in `DefaultHtmlGenerator` - correct placement of `DefaultHtmlGenerator.GetValidationAttributes()` comment

- Tested out Merge and MergeAttributes. #1319

NTaylorMullen · 2014-10-15T00:30:54Z

Closing so I can reopen against TagHelpersFeature.

dougbu reviewed Oct 10, 2014
View reviewed changes

NTaylorMullen reviewed Oct 10, 2014
View reviewed changes

NTaylorMullen force-pushed the TagHelpers_CopyHelpers branch from 5ff3854 to 3b4fe50 Compare October 10, 2014 06:42

pranavkm and others added 2 commits October 10, 2014 11:54

Updating functional tests to restore CallContextServiceLocator.Locato…

ad20844

…r.Service on test finish

Adding CancellationTokenModelBinder.

e319fef

dougbu force-pushed the taghelper.refactor.1243 branch from 89b19e2 to 42a508d Compare October 10, 2014 19:30

rynowak and others added 11 commits October 10, 2014 13:41

Add WebApiCompatShim project structure

f663452

Fix for #1275 - Adding ApiController

d9fe305

This change includes the basic properties that we're providing for compatability as well as some functional tests and unit tests that verify that ApiController can be a controller class.

Fix for issue #1281 - Add ModelBinder for HttpRequestMessage

aad3ae4

This change adds a ModelBinder that can bind an HttpRequestMessage to an action parameter. This builds on an earlier change to construct and store the request message in the HttpContext via an http feature.

Fix issue #1280 - Add HttpResponseMessageFormatter

22869b4

Adds a formatter that can convert an HttpResponseMessage returned from an action into HttpContext.Response output.

Adding ApiController.Validate : Fixes #1286

5a83383

Separate ApiControllers from MVC Controllers in routing

9ad3d5e

Reacting to CoreCLR version changes

7fabb80

NTaylorMullen force-pushed the TagHelpers_CopyHelpers branch from 3b4fe50 to b1918ba Compare October 10, 2014 23:39

dougbu reviewed Oct 11, 2014
View reviewed changes

pranavkm and others added 2 commits October 13, 2014 05:15

Removing unused types

d912f6c

Fixes #1344

Fix unit test

4166c8c

NTaylorMullen force-pushed the taghelper.refactor.1243 branch from 42a508d to 11c1354 Compare October 13, 2014 17:52

NTaylorMullen force-pushed the TagHelpers_CopyHelpers branch from be24e23 to c175091 Compare October 13, 2014 17:53

pranavkm and others added 3 commits October 13, 2014 14:34

Modify Razor components to use RazorViewEngineOptions.FileSystem

a633ef4

Fixes #1302

[Fixes #809] Multiple [Http*] verbs should create multiple actions

3937661

NTaylorMullen force-pushed the taghelper.refactor.1243 branch from 11c1354 to ff2f78d Compare October 14, 2014 00:42

NTaylorMullen force-pushed the TagHelpers_CopyHelpers branch from c175091 to e0a0206 Compare October 14, 2014 00:43

pranavkm and others added 4 commits October 13, 2014 17:44

Adding RenderSectionAsync to RazorPage

4ec6da1

Fixes #845

[Fixes #1331] Dispose HttpResponseMessage once its written out in Htt…

dd587f7

…pResponseMessageOutputFormatter

Ensure PDB writer component is available before emiting PDB

3f29de5

Ported from aspnet/dnx@36cd490 Fixes #1324

updating ILogger, see aspnet/Logging#3

0f5bbdf

pranavkm and others added 12 commits October 14, 2014 12:22

Removing Microsoft.AspNet.Mvc dependency from ModelBinding

d9ebb37

Add Html.Partial - sync versions of Html.PartialAsync

a41b9dc

Fixes #1107

Modify precompilation to always generate instrumentation

2d67f2f

[Issue #1133] RedirectToActionResult and UrlHelper should use HostStr…

1680616

…ing, PathString, etc. To build Urls. Added tests to describe the current behaviour with Unicode hosts.

Add TagHelperSample.Web

aaaf021

Add IHtmlGenerator to DI and enable MVC tag helpers in TagHelperSam…

056baf4

…ple.Web - also fix a couple of minor issues in TagHelperSample.Web

Add TextAreaTagHelper and Microsoft.AspNet.Mvc.TagHelpers project

408e108

- rest of #1243 and all of #1244 - needs a few utility methods for copying `TagBuilder` to `TagHelperOutput` - but works as-is

Add tests of TextAreaTagHelper

1b181d3

- new Microsoft.AspNet.Mvc.TagHelpers.Test project - bit of test infrastructure -- `TestableHtmlGenerator` - short-curcuits validation attribute and AntiForgery additions - should help when testing all MVC tag helpers

Add extensions for TagHelperOutput to copy from TagBuilder.

199a8e2

- Tested out Merge and MergeAttributes. #1319

NTaylorMullen force-pushed the TagHelpers_CopyHelpers branch from e0a0206 to 199a8e2 Compare October 15, 2014 00:30

NTaylorMullen closed this Oct 15, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add copy helpers for TagHelperOutput from TagBuilder. #1322

Add copy helpers for TagHelperOutput from TagBuilder. #1322

Uh oh!

NTaylorMullen commented Oct 10, 2014

Uh oh!

dougbu Oct 10, 2014

Uh oh!

dougbu commented Oct 10, 2014

Uh oh!

NTaylorMullen commented Oct 10, 2014

Uh oh!

NTaylorMullen Oct 10, 2014

Uh oh!

dougbu Oct 11, 2014

Uh oh!

dougbu commented Oct 11, 2014

Uh oh!

dougbu commented Oct 13, 2014

Uh oh!

NTaylorMullen commented Oct 14, 2014

Uh oh!

NTaylorMullen commented Oct 15, 2014

Uh oh!

Uh oh!

Add copy helpers for TagHelperOutput from TagBuilder. #1322

Add copy helpers for TagHelperOutput from TagBuilder. #1322

Uh oh!

Conversation

NTaylorMullen commented Oct 10, 2014

Uh oh!

dougbu Oct 10, 2014

Choose a reason for hiding this comment

Uh oh!

dougbu commented Oct 10, 2014

Uh oh!

NTaylorMullen commented Oct 10, 2014

Uh oh!

NTaylorMullen Oct 10, 2014

Choose a reason for hiding this comment

Uh oh!

dougbu Oct 11, 2014

Choose a reason for hiding this comment

Uh oh!

dougbu commented Oct 11, 2014

Uh oh!

dougbu commented Oct 13, 2014

Uh oh!

NTaylorMullen commented Oct 14, 2014

Uh oh!

NTaylorMullen commented Oct 15, 2014

Uh oh!

Uh oh!