Upgrades and stuff #35
Conversation
|
This includes #34, will rebase once that is merged. |
|
|
||
| [dev-dependencies] | ||
| skeptic = "0.5" | ||
| skeptic = "0.13" |
There was a problem hiding this comment.
Wow, that's a big jump from 0.5 to 0.13! :)
Cargo.toml
Outdated
| @@ -16,7 +16,7 @@ build = "build.rs" | |||
| colored = "1.5" | |||
| difference = "1.0" | |||
| error-chain = "0.11" | |||
| rustc-serialize = "0.3" | |||
| json = "0.11" | |||
There was a problem hiding this comment.
I'd usually prefer to use serde_json everywhere, but it's fine to go with this crate here as it does what we need it to do and also has no dependencies.
There was a problem hiding this comment.
I went with it for that and because I thought serde_json was implemented in terms of it which I just found out it isn't.
There was a problem hiding this comment.
I've gone ahead and switched it to serde_json (already shows up in the dependency tree anyways).
Merge conflict (retrying...) |
Timed out |
|
bors r+ |
Merge conflict |
- `.doesnt_print`, `.doesnt_print_exactly` - `.doesnt_print_error`, `.doesnt_print_error_exactly` Fixes assert-rs#31
|
I wonder if I can do it bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make epage a reviewer |
|
Ah, I take it bors auto-merges |
|
I added you as a collaborator on github and with bors! In the meantime, let's give this another try: bors r+ |
Build succeeded |
Dependencies
Otherwise, I moved Assert into its own module in prep for future refactorings.