This repository was archived by the owner on Dec 29, 2021. It is now read-only.
Support more than one output assertion #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes #35 and will need to be rebased. |
|
Thanks! (Needs a rebase after #35.) I can see why you want this, and I think this is a good idea. I don't know if the API is obvious enough, though. People might be expecting the usual "builder" behavior of the second call replacing the effects of the first. In the very least, can you add some tests? :) |
BREAKING CHANGE: Setting a new output assertion will not overwrite the previous one.
|
Replaced by #38 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Setting a new output assertion will not overwrite the
previous one.