Repository navigation
Preserve non-UTF-8 paths in build-cache GC records - #530
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
force-pushed
the
charlie/non-utf8-gc-identities
branch
from
November 10, 2026 12:03
78a5546 to
131e969
Compare
This was referenced Nov 10, 2026
charliermarsh
marked this pull request as ready for review
November 10, 2026 12:14
charliermarsh
force-pushed
the
charlie/non-utf8-gc-identities
branch
from
November 10, 2026 12:27
131e969 to
bf2f799
Compare
charliermarsh
added a commit
to astral-experiments/ohm
that referenced
this pull request
Nov 10, 2026
## Summary Ohm 1.99.0-31 lets optimized Rust libraries reuse a checked LLVM object before optimization. LLVM can also reuse an object after bounded source edits when every observed line has an unambiguous destination. These paths target incremental O1 builds on x86-64 Linux. [LLVM stack](astral-experiments/ohm-llvm#22) · [Rust compiler change](astral-experiments/ohm-rust#397) Rustc preserves caller locations across worktrees, indexes consecutive procedural-macro spans directly, and retains the joined span of type-relative struct paths. Clippy uses those paths when checking patterns and expressions. [Rust span changes](astral-experiments/ohm-rust#400) · [Clippy companion](astral-experiments/ohm-rust-clippy#83) Cargo documents libraries with names up to 242 bytes and retains active shared builds whose compiler or driver path contains non-UTF-8 bytes. Its checked-in lockfile also matches dependency resolution in a read-only checkout. [Cargo stack](astral-experiments/ohm-cargo#530)
charliermarsh
force-pushed
the
charlie/non-utf8-gc-identities
branch
from
November 17, 2026 06:26
bf2f799 to
0e91fb8
Compare
charliermarsh
force-pushed
the
charlie/non-utf8-gc-identities
branch
from
November 17, 2026 07:02
0e91fb8 to
39b50e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A non-UTF-8 path to rustc or its driver prevented Cargo from recording which toolchain owned a shared build. A later
cargo gc --max-age 365dcould remove a registry artifact that a warmcargo checkhad just used.Cargo records UTF-8 paths as JSON strings and other Unix paths as their original bytes. A warm check can register a previously untracked build, and removing the driver still lets GC retire it. The regression exercises the actual filename on filesystems that accept it and checks the byte representation on macOS even when APFS rejects that name.
In the combined Linux SDK,
cargo gcretained the warm registry artifact with either 0xff or 0xfe in the driver directory name. Removing the driver made the next collection delete the artifact in both cases. Packaged SDK replayCloses #529.