Repository navigation
Retain the joined span of type-relative struct paths - #400
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
force-pushed
the
charlie/ohm-30-keep-struct-path-spans
branch
from
November 10, 2026 12:03
dfd1ad4 to
5e8f539
Compare
charliermarsh
changed the base branch from
charlie/pin-components-release-30
to
charlie/ohm-30-dense-proc-macro-span-handles
November 10, 2026 12:04
charliermarsh
force-pushed
the
charlie/ohm-30-keep-struct-path-spans
branch
from
November 10, 2026 12:09
5e8f539 to
0578e8f
Compare
This was referenced Nov 10, 2026
charliermarsh
marked this pull request as ready for review
November 10, 2026 12:14
charliermarsh
force-pushed
the
charlie/ohm-30-keep-struct-path-spans
branch
3 times, most recently
from
November 10, 2026 13:02
9956416 to
ec60095
Compare
charliermarsh
added a commit
to astral-experiments/ohm
that referenced
this pull request
Nov 10, 2026
## Summary Ohm 1.99.0-31 lets optimized Rust libraries reuse a checked LLVM object before optimization. LLVM can also reuse an object after bounded source edits when every observed line has an unambiguous destination. These paths target incremental O1 builds on x86-64 Linux. [LLVM stack](astral-experiments/ohm-llvm#22) · [Rust compiler change](astral-experiments/ohm-rust#397) Rustc preserves caller locations across worktrees, indexes consecutive procedural-macro spans directly, and retains the joined span of type-relative struct paths. Clippy uses those paths when checking patterns and expressions. [Rust span changes](astral-experiments/ohm-rust#400) · [Clippy companion](astral-experiments/ohm-rust-clippy#83) Cargo documents libraries with names up to 242 bytes and retains active shared builds whose compiler or driver path contains non-UTF-8 bytes. Its checked-in lockfile also matches dependency resolution in a read-only checkout. [Cargo stack](astral-experiments/ohm-cargo#530)
charliermarsh
force-pushed
the
charlie/ohm-30-keep-struct-path-spans
branch
from
November 17, 2026 07:32
ec60095 to
28729f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the first workspace check after uv #19612, this change alone saved 83.16 million rustc instructions in
uv-resolver(1.738%). Across all 14 compiler processes, six independently primed comparisons against Ohm −30 saved 0.320–0.331%. Theuvlibrary used 0.128% more instructions anduv-cliused 0.167% more at the median. uv editRustc repeatedly joins the type and final segment of a struct path to find its span. We now retain that span when both parts have the same syntax context. Mixed-context paths still consult the metavariable span map. Clippy borrows the underlying path when its lints inspect struct expressions and patterns and when
#[clippy::author]generates code for them. Rustc CI now type-checks the bundled Clippy against this HIR on Linux and macOS. Clippy companionWith the full −31 SDK, four order-balanced replays of that edit used 1.88% fewer instructions in
uv-resolverand 0.15% fewer instructions in theuvlibrary compared with signed −30. Both SDKs rebuilt the same crates and emitted identical struct-pattern diagnostics. Packaged SDK replay