Skip to content

Avoid unrelated span reads for allowed unreachable-code lints - #391

Open
charliermarsh wants to merge 1 commit into
charlie/ohm-29-local-incoherent-impl-lookupfrom
charlie/ohm-29-scope-unreachable-lint-inputs
Open

charliermarsh wants to merge 1 commit into
charlie/ohm-29-local-incoherent-impl-lookupfrom
charlie/ohm-29-scope-unreachable-lint-inputs

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Reading an unreachable-code lint’s span only when reporting it let Lock::satisfies reuse its type check. Over the local-impl lookup change, the edited resolver used 2.67% fewer instructions and the 14 compiler processes used 0.52% fewer. The final uv library used 0.15% more. Forced warnings and macro diagnostics still report the original source location. uv edit

@charliermarsh
charliermarsh force-pushed the charlie/ohm-29-scope-unreachable-lint-inputs branch from a8a5dd9 to 527bc82 Compare November 9, 2026 17:31
@charliermarsh
charliermarsh marked this pull request as ready for review November 9, 2026 17:38
@charliermarsh
charliermarsh added this pull request to stack #395 November 9, 2026 17:38
@charliermarsh
charliermarsh removed this pull request from stack #395 November 12, 2026 17:29
@charliermarsh
charliermarsh added this pull request to stack #413 November 12, 2026 17:29
@charliermarsh
charliermarsh force-pushed the charlie/ohm-29-scope-unreachable-lint-inputs branch from 527bc82 to d39d2b4 Compare November 17, 2026 07:31
@charliermarsh
charliermarsh removed this pull request from stack #413 November 17, 2026 07:33
@charliermarsh
charliermarsh added this pull request to stack #426 November 17, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant