Skip to content

Skip incoherent impl lookups for locally defined types - #392

Open
charliermarsh wants to merge 1 commit into
charlie/ohm-28-drop-unrelated-typecheck-inputsfrom
charlie/ohm-29-local-incoherent-impl-lookup
Open

charliermarsh wants to merge 1 commit into
charlie/ohm-28-drop-unrelated-typecheck-inputsfrom
charlie/ohm-29-local-incoherent-impl-lookup

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Ten more uv-resolver functions reused their type checks after a seven-file uv edit. The marginal savings over the diagnostic-input change were 2.32% in the resolver and 0.54% across all compiler processes. Rustc can return an empty foreign incoherent-impl list for a type defined in the current crate. Its local impls already have their own index. uv edit

@charliermarsh
charliermarsh changed the base branch from charlie/ohm-29-drop-unrelated-typecheck-inputs to charlie/ohm-28-drop-unrelated-typecheck-inputs November 9, 2026 15:01
@charliermarsh
charliermarsh force-pushed the charlie/ohm-29-local-incoherent-impl-lookup branch from 5d5abfa to c3a4daa Compare November 9, 2026 17:31
@charliermarsh
charliermarsh marked this pull request as ready for review November 9, 2026 17:38
@charliermarsh
charliermarsh added this pull request to stack #395 November 9, 2026 17:38
@charliermarsh
charliermarsh removed this pull request from stack #395 November 12, 2026 17:29
@charliermarsh
charliermarsh added this pull request to stack #413 November 12, 2026 17:29
@charliermarsh
charliermarsh force-pushed the charlie/ohm-29-local-incoherent-impl-lookup branch from c3a4daa to 349718b Compare November 17, 2026 07:32
@charliermarsh
charliermarsh removed this pull request from stack #413 November 17, 2026 07:33
@charliermarsh
charliermarsh added this pull request to stack #426 November 17, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant