Repository navigation
Skip incoherent impl lookups for locally defined types - #392
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
changed the base branch from
charlie/ohm-29-drop-unrelated-typecheck-inputs
to
charlie/ohm-28-drop-unrelated-typecheck-inputs
November 9, 2026 15:01
charliermarsh
force-pushed
the
charlie/ohm-29-local-incoherent-impl-lookup
branch
from
November 9, 2026 17:31
5d5abfa to
c3a4daa
Compare
charliermarsh
marked this pull request as ready for review
November 9, 2026 17:38
charliermarsh
force-pushed
the
charlie/ohm-29-local-incoherent-impl-lookup
branch
from
November 17, 2026 07:32
c3a4daa to
349718b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ten more
uv-resolverfunctions reused their type checks after a seven-file uv edit. The marginal savings over the diagnostic-input change were 2.32% in the resolver and 0.54% across all compiler processes. Rustc can return an empty foreign incoherent-impl list for a type defined in the current crate. Its local impls already have their own index. uv edit