Skip to content

Declare support for markdown files - #950

Merged
amyreese merged 1 commit into
mainfrom
amy/markdown-support
Feb 10, 2026
Merged

amyreese merged 1 commit into
mainfrom
amy/markdown-support

Conversation

@amyreese

@amyreese amyreese commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

Changes necessary to support markdown formatting in ruff's LSP in vscode:
astral-sh/ruff#23063

@amyreese
amyreese force-pushed the amy/markdown-support branch from bece24a to 3bd7776 Compare February 5, 2026 20:01
@amyreese
amyreese requested a review from ntBre February 5, 2026 20:08

@ntBre ntBre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, but it's probably best to get a look from Dhruv too, and I assume the Ruff PR needs to land first as well?

@amyreese

amyreese commented Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

I think this is ok to land, because it won't go out until the next time we release the extension. We should wait for the Ruff PR to land and the next patch release at the very least before publishing an update to the vscode plugin.

@amyreese
amyreese requested a review from dhruvmanila February 5, 2026 20:17
@amyreese
amyreese merged commit b6e2412 into main Feb 10, 2026
8 checks passed
@amyreese
amyreese deleted the amy/markdown-support branch February 10, 2026 18:42
ntBre added a commit to astral-sh/ruff that referenced this pull request Jul 30, 2026
Summary
--

This PR adds TOML linting and fixing support to the LSP following
#26772. It's organized as 3
initial refactoring commits followed by the two commits actually adding
TOML support.

After this lands, we'll also need to add TOML support in the VS Code
extension, like we did for Markdown files in
astral-sh/ruff-vscode#950.

Test Plan
--

New e2e tests
ntBre added a commit that referenced this pull request Jul 31, 2026
Summary
--

Related to astral-sh/ruff#26862. I copied the Markdown changes from
#950.

Closes astral-sh/ruff#27088.

Test Plan
--

<img width="964" height="576" alt="Screenshot 2026-07-30 at 12 17 29"
src="https://github.com/user-attachments/assets/7818bdc6-1c3a-4ffd-86b0-bd474d03ee6b"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants