Repository navigation
Declare support for markdown files - #950
Merged
Merged
Conversation
amyreese
force-pushed
the
amy/markdown-support
branch
from
February 5, 2026 20:01
bece24a to
3bd7776
Compare
ntBre
reviewed
Feb 5, 2026
ntBre
left a comment
Contributor
There was a problem hiding this comment.
This looks reasonable to me, but it's probably best to get a look from Dhruv too, and I assume the Ruff PR needs to land first as well?
Contributor
Author
|
I think this is ok to land, because it won't go out until the next time we release the extension. We should wait for the Ruff PR to land and the next patch release at the very least before publishing an update to the vscode plugin. |
dhruvmanila
approved these changes
Feb 9, 2026
ntBre
added a commit
to astral-sh/ruff
that referenced
this pull request
Jul 30, 2026
Summary -- This PR adds TOML linting and fixing support to the LSP following #26772. It's organized as 3 initial refactoring commits followed by the two commits actually adding TOML support. After this lands, we'll also need to add TOML support in the VS Code extension, like we did for Markdown files in astral-sh/ruff-vscode#950. Test Plan -- New e2e tests
ntBre
added a commit
that referenced
this pull request
Jul 31, 2026
Summary -- Related to astral-sh/ruff#26862. I copied the Markdown changes from #950. Closes astral-sh/ruff#27088. Test Plan -- <img width="964" height="576" alt="Screenshot 2026-07-30 at 12 17 29" src="https://github.com/user-attachments/assets/7818bdc6-1c3a-4ffd-86b0-bd474d03ee6b" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes necessary to support markdown formatting in ruff's LSP in vscode:
astral-sh/ruff#23063