-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add to dependency-groups.dev in uv add --dev
#8570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7ea560a to
6bb37e4
Compare
|
I do wonder if |
Yeah I think this would be "best" in that it avoids introducing two separate tables. I think we'll get questions otherwise. I don't think it's critical, but unless it was a pain I'd probably do it. |
|
Na it's easy. Will fix. |
|
But should |
|
I think it's fine either way, but I would be a little surprised if it didn't make a separate table. |
| // TODO(zanieb): Once we support `remove --group`, add a warning here. | ||
| DependencyType::Group(group) => { | ||
| warn_user!( | ||
| "`{name}` is a dependency in the `{group}` group; try calling `uv remove --group {group}`", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "`{name}` is a dependency in the `{group}` group; try calling `uv remove --group {group}`", | |
| "`{name}` is a `{group}` group dependency; try calling `uv remove --group {group}`", |
This looks better into my eyes :)
6bb37e4 to
da00028
Compare
da00028 to
0e3c6a7
Compare
## Summary `uv add --dev` now updates the `dependency-groups.dev` section, rather than `tool.uv.dev-dependencies` -- unless the dependency is already present in `tool.uv.dev-dependencies`. `uv remove --dev` now removes from both `dependency-groups.dev` and `tool.uv.dev-dependencies`. `--dev` and `--group dev` are now treated equivalently in `uv add` and `uv remove`.
Summary
uv add --devnow updates thedependency-groups.devsection, rather thantool.uv.dev-dependencies-- unless the dependency is already present intool.uv.dev-dependencies.uv remove --devnow removes from bothdependency-groups.devandtool.uv.dev-dependencies.--devand--group devare now treated equivalently inuv addanduv remove.