Skip to content

Make point_map.fits plotting more friendly.#439

Merged
delucchi-cmu merged 3 commits intomainfrom
issue/417/density
Dec 4, 2024
Merged

Make point_map.fits plotting more friendly.#439
delucchi-cmu merged 3 commits intomainfrom
issue/417/density

Conversation

@delucchi-cmu
Copy link
Copy Markdown
Contributor

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (56321ef) to head (d855202).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   92.90%   93.29%   +0.39%     
==========================================
  Files          47       47              
  Lines        2029     2044      +15     
==========================================
+ Hits         1885     1907      +22     
+ Misses        144      137       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2024

Before [56321ef] After [592db70] Ratio Benchmark (Parameter)
23.5±0.2ms 23.6±0.09ms 1 benchmarks.MetadataSuite.time_load_partition_info_order6
124±1ms 125±2ms 1 benchmarks.time_test_alignment_even_sky
94.7±0.6ms 94.2±0.5ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
382±1ms 379±2ms 0.99 benchmarks.Suite.time_outer_pixel_alignment
110±1ms 109±1ms 0.99 benchmarks.Suite.time_paths_creation
47.0±0.6ms 46.5±0.9ms 0.99 benchmarks.Suite.time_pixel_tree_creation
95.8±0.8ms 94.0±0.5ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order7
13.3±0.4ms 13.0±0.5ms 0.98 benchmarks.Suite.time_inner_pixel_alignment
1.05±0.03ms 1.02±0.01ms 0.97 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu requested a review from hombit December 3, 2024 20:45
Copy link
Copy Markdown
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. See a couple of suggestions below.

Comment thread src/hats/inspection/visualize_catalog.py Outdated
Comment thread src/hats/pixel_math/healpix_shim.py Outdated
@delucchi-cmu delucchi-cmu merged commit 081961a into main Dec 4, 2024
@delucchi-cmu delucchi-cmu deleted the issue/417/density branch December 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plot_points method name is confusing

2 participants