This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Improve function-params regex #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, add a constructor regex -Fixes #183
|
@bucaran this should fix both your issues - I added in your constructor as a new spec 😄. /cc @Victorystick if you want to take a look. |
|
👏 Awesome. |
| 'numbers': | ||
| 'patterns': [ | ||
| { | ||
| 'match': '\\b((0(x|X)[0-9a-fA-F]+)|(0(b|B)[01]+)|(0(o|O)[0-7]+)|([0-9]+(\\.[0-9]+)?)((e|E)[+-]?[0-9]+)?)\\b' |
There was a problem hiding this comment.
Can JavaScript decimal literals have an optional sign on the front of them too? Or is it like in Python where there are only positive literals that get negated?
|
Looks good to me ⛵ |
winstliu
pushed a commit
that referenced
this pull request
Aug 2, 2015
Improve function-params regex
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
function-paramsregex was very archaic and hard to understand, so I've replaced it with a system that doesn't have nested patterns and can be easily expanded upon. It's also much more robust than the previous system in that it tokenizes brackets, strings, numbers, and more.In addition, I've also added a new regex rule called
entity.name.constructor.jsfor tokenizingconstructor()-type functions. The name can probably be improved :).Fixes #183.