docs(ekf_localizer): improve ekf_localization readme readability#664
docs(ekf_localizer): improve ekf_localization readme readability#664Motsu-san wants to merge 4 commits intoautowarefoundation:mainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
72bdff9 to
fdcdd7e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 50.27% 50.27%
=======================================
Files 348 348
Lines 22023 22023
Branches 9795 9795
=======================================
Hits 11071 11071
Misses 9877 9877
Partials 1075 1075
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e3813c3 to
2973334
Compare
2973334 to
4b15bf0
Compare
4b15bf0 to
7b4744e
Compare
There was a problem hiding this comment.
It seems like the file size has increased by more than 3 times (4.79 KB to 16.2 KB). Do you know the reason?
It's not a big size in total anyways so I'm okay to merge, but I just wanted to know if there is a way to keep the file size small as possible.
There was a problem hiding this comment.
The PNG format supports background transparency (alpha channel), compressing unnecessary parts (in this case, the white background) as transparent data, so it results in smaller file sizes.
The background is dominant in these images, I think it makes sense that adding color to it makes the file size increased by a few times.
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
for dark mode appearance Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
autowarefoundation#668 Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
7b4744e to
c497f08
Compare
sasakisasaki
left a comment
There was a problem hiding this comment.
Thank you very much for nice refactoring! 👍
If I understand correctly, perhaps for the pictures in diagnostics (not formula part), I guess we can omit the pictures. Please see the attached picture. It seems the purpose of pictures in diagnostics is to show the default value, plugin name, ... etc. If so, we can write such the information in the table without providing the pictures.
Perhaps I'm missing something. Your feedback is highly appreciated!
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Description
This is for improvement the ekf_localization docs readability.
Before
Diagnostic conditions
Equation images
After
Diagnostic conditions
Due to the large size, please see this link
Equation images
Related links
#668
How was this PR tested?
Please see the github page on this branch on both right mode and dark.
Notes for reviewers
This PR will be merged simultaneously with #668.
Interface changes
None.
Effects on system behavior
None.