Skip to content

feat(ekf_localizer)!: subdivide ekf_localizer diagnostics#668

Open
Motsu-san wants to merge 6 commits intoautowarefoundation:mainfrom
Motsu-san:feat/subdivide_ekf_localizer_diagnostics_items
Open

feat(ekf_localizer)!: subdivide ekf_localizer diagnostics#668
Motsu-san wants to merge 6 commits intoautowarefoundation:mainfrom
Motsu-san:feat/subdivide_ekf_localizer_diagnostics_items

Conversation

@Motsu-san
Copy link
Contributor

@Motsu-san Motsu-san commented Oct 8, 2025

Description

When the ekf_localizer diagnostics status is ERROR or WARN, it is not clear why or where it happens at a grance. We can get only that "localization: ekf_localizer" has "ERROR" in the header of diagnostic message.
Therefore, I've made this pull-request subdivides the diagnostics.

Related links

The following pull requests must be merged at once and in sequence.

Parent Issue:
https://github.com/orgs/autowarefoundation/discussions/6510

Private Links:

How was this PR tested?

  1. Build Autoware with this changes(Before run build, replacing file or editing repos).
  2. ros2 bag play the autoware sample data with autoware sample map.
  3. Check the diagnostics with rqt_rintime_monitor.

Notes for reviewers

None.

Interface changes

The ekf_localizer diagnostics content "localization: ekf_localizer" is replaced to the combined message with the following items.

    "localization: ekf_localizer: is_activated"
    "localization: ekf_localizer: is_set_initialpose"
    "localization: ekf_localizer: pose_no_update_count"
    "localization: ekf_localizer: pose_queue_size"
    "localization: ekf_localizer: pose_delay_time"
    "localization: ekf_localizer: pose_mahalanobis_distance"
    "localization: ekf_localizer: twist_no_update_count"
    "localization: ekf_localizer: twist_queue_size"
    "localization: ekf_localizer: twist_delay_time"
    "localization: ekf_localizer: twist_mahalanobis_distance"
    "localization: ekf_localizer: cov_ellipse_long_axis_size"
    "localization: ekf_localizer: cov_ellipse_lateral_direction_size"

Before

image

After

image image image image image image image image image image image image

Effects on system behavior

None.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Motsu-san Motsu-san changed the title feat(ekf_localizer)/subdivide ekf_localizer diagnostics feat!(ekf_localizer)/subdivide ekf_localizer diagnostics Oct 8, 2025
@Motsu-san Motsu-san added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Oct 8, 2025
@Motsu-san Motsu-san changed the title feat!(ekf_localizer)/subdivide ekf_localizer diagnostics feat!(ekf_localizer): subdivide ekf_localizer diagnostics Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.43%. Comparing base (d4cb9e0) to head (234ca8d).
⚠️ Report is 94 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   50.26%   50.43%   +0.16%     
==========================================
  Files         348      348              
  Lines       22034    22049      +15     
  Branches     9802     9831      +29     
==========================================
+ Hits        11076    11120      +44     
+ Misses       9885     9854      -31     
- Partials     1073     1075       +2     
Flag Coverage Δ *Carryforward flag
daily-humble 50.08% <ø> (+<0.01%) ⬆️ Carriedforward from f61eb89
daily-jazzy 49.50% <ø> (+0.02%) ⬆️ Carriedforward from f61eb89
differential-humble 57.11% <100.00%> (?)
total 50.26% <ø> (-0.07%) ⬇️ Carriedforward from f61eb89
total-humble 50.08% <ø> (+<0.01%) ⬆️ Carriedforward from f61eb89
total-jazzy 49.48% <ø> (+<0.01%) ⬆️ Carriedforward from f61eb89

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Motsu-san Motsu-san changed the title feat!(ekf_localizer): subdivide ekf_localizer diagnostics feat(ekf_localizer)!: subdivide ekf_localizer diagnostics Oct 9, 2025
@Motsu-san Motsu-san marked this pull request as ready for review October 9, 2025 23:46
Motsu-san added a commit to Motsu-san/autoware_core that referenced this pull request Oct 10, 2025
autowarefoundation#668

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
@Motsu-san Motsu-san force-pushed the feat/subdivide_ekf_localizer_diagnostics_items branch from 64840ae to f914182 Compare October 17, 2025 07:37
@Motsu-san Motsu-san force-pushed the feat/subdivide_ekf_localizer_diagnostics_items branch from 981660e to d7d6979 Compare October 23, 2025 07:28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, Is this header file meant to be exported?(i.e., is it expected to be included by some other packages?)
If not, we might want to move it under src/ folder so that we don't have to worry about making changes to function signature in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for late replay. Thank you for your comment. I agree with you. Though it may be needed before, any source except for ekf localizer doesn't seem to refer it. I think it is better to locate in src folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the pull-request for it. I'm currently verifying whether header files can be moved.

Motsu-san added a commit to Motsu-san/autoware_core that referenced this pull request Nov 25, 2025
autowarefoundation#668

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
mitsudome-r pushed a commit to Motsu-san/autoware_core that referenced this pull request Nov 26, 2025
autowarefoundation#668

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
@Motsu-san Motsu-san force-pushed the feat/subdivide_ekf_localizer_diagnostics_items branch from d7d6979 to 8f468f1 Compare January 6, 2026 03:06
Motsu-san added a commit to Motsu-san/autoware_core that referenced this pull request Jan 6, 2026
autowarefoundation#668

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Motsu-san added a commit to Motsu-san/autoware_core that referenced this pull request Jan 8, 2026
autowarefoundation#668

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
when the node is NOT activated or initial pose is NOT set

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
to the required functions

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
@Motsu-san Motsu-san force-pushed the feat/subdivide_ekf_localizer_diagnostics_items branch from 8f468f1 to c1b5cfa Compare January 8, 2026 05:58
@stale
Copy link

stale bot commented Mar 17, 2026

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants