feat(ekf_localizer)!: subdivide ekf_localizer diagnostics#668
feat(ekf_localizer)!: subdivide ekf_localizer diagnostics#668Motsu-san wants to merge 6 commits intoautowarefoundation:mainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
+ Coverage 50.26% 50.43% +0.16%
==========================================
Files 348 348
Lines 22034 22049 +15
Branches 9802 9831 +29
==========================================
+ Hits 11076 11120 +44
+ Misses 9885 9854 -31
- Partials 1073 1075 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
autowarefoundation#668 Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
64840ae to
f914182
Compare
981660e to
d7d6979
Compare
There was a problem hiding this comment.
Just out of curiosity, Is this header file meant to be exported?(i.e., is it expected to be included by some other packages?)
If not, we might want to move it under src/ folder so that we don't have to worry about making changes to function signature in the future.
There was a problem hiding this comment.
I'm sorry for late replay. Thank you for your comment. I agree with you. Though it may be needed before, any source except for ekf localizer doesn't seem to refer it. I think it is better to locate in src folder.
There was a problem hiding this comment.
I made the pull-request for it. I'm currently verifying whether header files can be moved.
autowarefoundation#668 Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
autowarefoundation#668 Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
d7d6979 to
8f468f1
Compare
autowarefoundation#668 Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
autowarefoundation#668 Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
when the node is NOT activated or initial pose is NOT set Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
to the required functions Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
8f468f1 to
c1b5cfa
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Description
When the ekf_localizer diagnostics status is ERROR or WARN, it is not clear why or where it happens at a grance. We can get only that "localization: ekf_localizer" has "ERROR" in the header of diagnostic message.
Therefore, I've made this pull-request subdivides the diagnostics.
Related links
The following pull requests must be merged at once and in sequence.
Parent Issue:
https://github.com/orgs/autowarefoundation/discussions/6510
Private Links:
How was this PR tested?
Notes for reviewers
None.
Interface changes
The ekf_localizer diagnostics content "localization: ekf_localizer" is replaced to the combined message with the following items.
Before
After
Effects on system behavior
None.