Skip to content

feat(diagnostics): replace monitoring localization diagnostic items#1665

Open
Motsu-san wants to merge 3 commits intoautowarefoundation:mainfrom
Motsu-san:feat/modification_derived_from_new_diag_messages_of_ekf_localizer
Open

feat(diagnostics): replace monitoring localization diagnostic items#1665
Motsu-san wants to merge 3 commits intoautowarefoundation:mainfrom
Motsu-san:feat/modification_derived_from_new_diag_messages_of_ekf_localizer

Conversation

@Motsu-san
Copy link
Contributor

@Motsu-san Motsu-san commented Oct 8, 2025

Description

This pull-request replaces the monitoring ekf_localizer diagnostic to new ones.

Related link

autowarefoundation/autoware_core#668

How was this PR tested?

  1. Just before building Autoware, edit [AUTOWARE DIRECTORY]/src/universe/autoware_universe/system/autoware_dummy_diag_publisher/launch/dummy_diag_publisher.launch.xml as below
    <arg name="config_file" default="$(find-pkg-share autoware_launch)/config/system/diagnostics/dummy_diag_publisher.param.yaml"/>
  2. Build Autoware with this changes on autoware_core
  3. Replay a rosbag (sample rosbag is OK) a while
  4. Stop replaying
  5. Launch dummy_diag_publisher
    ros2 launch autoware_dummy_diag_publisher dummy_diag_publisher.launch.xml
  6. Output dummy diag
    ex. ros2 param set /dummy_diag_publisher "localization: ekf_localizer: is_activated.status" "Warn"
  7. Restart replaying and Stop again about a second later.
  8. Confirm if the error/warn messages appear in the launch terminal
image

Notes for reviewers

This PR will be merged simultaneously with autowarefoundation/autoware_core#668.

Effects on system behavior

None.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Oct 8, 2025
@Motsu-san Motsu-san force-pushed the feat/modification_derived_from_new_diag_messages_of_ekf_localizer branch 2 times, most recently from 73c8150 to a3ac1e8 Compare October 8, 2025 02:00
@Motsu-san Motsu-san marked this pull request as ready for review October 9, 2025 05:50
@Motsu-san Motsu-san force-pushed the feat/modification_derived_from_new_diag_messages_of_ekf_localizer branch 2 times, most recently from 5f2ee79 to 77eeb2c Compare October 9, 2025 06:00
@Motsu-san
Copy link
Contributor Author

"style(pre-commit): autofix" made a "pre-commit.ci - pr" error
https://github.com/orgs/autowarefoundation/discussions/6506

@Motsu-san Motsu-san added run:build-and-test-differential component:system System design and integration. (auto-assigned) labels Oct 10, 2025
@Motsu-san Motsu-san force-pushed the feat/modification_derived_from_new_diag_messages_of_ekf_localizer branch 2 times, most recently from 94819a9 to aa630ae Compare October 14, 2025 06:46
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Screenshot from 2025-10-17 19-39-33

@stale
Copy link

stale bot commented Dec 16, 2025

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale label Dec 16, 2025
to new ekf_localizer diagnostics

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
@Motsu-san Motsu-san force-pushed the feat/modification_derived_from_new_diag_messages_of_ekf_localizer branch from aa630ae to 432b1bc Compare January 6, 2026 03:07
@stale stale bot removed the status:stale label Jan 6, 2026
@stale
Copy link

stale bot commented Mar 7, 2026

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:localization Vehicle's position determination in its environment. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential status:stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants