Skip to content

fix(planning_evaluaotr): prevent abnormal value for ttc#11138

Merged
kosuke55 merged 1 commit intoautowarefoundation:mainfrom
tier4:fix/ttc_metrics_awf
Aug 11, 2025
Merged

fix(planning_evaluaotr): prevent abnormal value for ttc#11138
kosuke55 merged 1 commit intoautowarefoundation:mainfrom
tier4:fix/ttc_metrics_awf

Conversation

@kosuke55
Copy link
Copy Markdown
Contributor

@kosuke55 kosuke55 commented Aug 8, 2025

Description

obstacle_ttc sometimes becomes abnormally large.
The exact reason is unknown (maybe issue on application side. refer to Related Links) , but it may become large when p0 is not initialized, so a check has been added.
In addition, division by extremely small values has been prevented.

Related links

How was this PR tested?

build only.

( ↓ faild due to other issue

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Aug 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 20.31%. Comparing base (341e08a) to head (97bc06d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...lanning_evaluator/src/metrics/obstacle_metrics.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11138      +/-   ##
==========================================
+ Coverage   20.19%   20.31%   +0.11%     
==========================================
  Files        1512     1513       +1     
  Lines      109519   109764     +245     
  Branches    35890    35950      +60     
==========================================
+ Hits        22113    22294     +181     
- Misses      70389    70619     +230     
+ Partials    17017    16851     -166     
Flag Coverage Δ *Carryforward flag
daily 21.77% <ø> (-0.01%) ⬇️ Carriedforward from 7795497
daily-cuda 20.19% <ø> (-0.01%) ⬇️ Carriedforward from 7795497
differential 34.79% <66.66%> (?)
total-cuda 20.18% <ø> (+0.02%) ⬆️ Carriedforward from 7795497

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@xtk8532704 xtk8532704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@kosuke55 kosuke55 merged commit ae5e35d into autowarefoundation:main Aug 11, 2025
67 of 68 checks passed
@kosuke55 kosuke55 deleted the fix/ttc_metrics_awf branch August 11, 2025 03:16
@github-project-automation github-project-automation bot moved this from To Triage to Done in Software Working Group Aug 11, 2025
kosuke55 added a commit that referenced this pull request Aug 12, 2025
naveen-mcw pushed a commit to naveen-mcw/autoware.universe that referenced this pull request Aug 12, 2025
xtk8532704 pushed a commit to tier4/autoware_universe that referenced this pull request Dec 26, 2025
xtk8532704 pushed a commit to tier4/autoware_universe that referenced this pull request Jan 16, 2026
xtk8532704 pushed a commit to tier4/autoware_universe that referenced this pull request Jan 16, 2026
…dation#11138)

Signed-off-by: xtk8532704 <1041084556@qq.com>
Signed-off-by: Kem (TiankuiXian) <temkei.kem@tier4.jp>
xtk8532704 pushed a commit to tier4/autoware_universe that referenced this pull request Jan 26, 2026
…dation#11138)

Signed-off-by: xtk8532704 <1041084556@qq.com>
Signed-off-by: Kem (TiankuiXian) <temkei.kem@tier4.jp>
mkquda pushed a commit to tier4/autoware_universe that referenced this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants