Skip to content

feat(lidar_marker_localizer): road surface lidar marker extension#11701

Draft
Motsu-san wants to merge 30 commits intoautowarefoundation:mainfrom
Motsu-san:feat/road_surface_lidar_marker_extension
Draft

feat(lidar_marker_localizer): road surface lidar marker extension#11701
Motsu-san wants to merge 30 commits intoautowarefoundation:mainfrom
Motsu-san:feat/road_surface_lidar_marker_extension

Conversation

@Motsu-san
Copy link
Contributor

@Motsu-san Motsu-san commented Nov 28, 2025

Description

This pull request adds and improves the Lidar Marker feature in Autoware Universe's autoware_lidar_marker_localizer to extend the function for road surface lidar marker.

Please open and merge this after the following pull-requests merged
#11574
autowarefoundation/autoware_launch#1695

Contents

  • Added Lidar Marker extension for road surface information
  • Updated documentation and README (as needed)

Related links

How was this PR tested?

Add unit tests for new features

Verify functionality in simulation environments with in-house data

  1. Apply this change to the latest Autoware manually
  2. Adjust launch files related
  3. Replay the data has road surface lidar markers
  4. Confirm the detection

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@Motsu-san Motsu-san added component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Nov 28, 2025
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Nov 28, 2025
@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 17.62452% with 215 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.68%. Comparing base (435a7f1) to head (d9c9775).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ar_marker_localizer/src/lidar_marker_localizer.cpp 22.88% 155 Missing ⚠️
...autoware_landmark_manager/src/landmark_manager.cpp 0.00% 43 Missing ⚠️
...mator_arbiter/src/stopper/stopper_lidar_marker.hpp 0.00% 12 Missing ⚠️
...imator_arbiter/src/pose_estimator_arbiter_core.cpp 0.00% 3 Missing and 1 partial ⚠️
...ose_estimator_arbiter/src/stopper/base_stopper.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11701      +/-   ##
==========================================
+ Coverage   18.05%   18.68%   +0.63%     
==========================================
  Files        1838     1869      +31     
  Lines      126279   127525    +1246     
  Branches    44164    46883    +2719     
==========================================
+ Hits        22796    23827    +1031     
- Misses      84517    85401     +884     
+ Partials    18966    18297     -669     
Flag Coverage Δ *Carryforward flag
daily 20.55% <ø> (+0.01%) ⬆️ Carriedforward from da67f7e
daily-cuda 18.05% <ø> (+<0.01%) ⬆️ Carriedforward from da67f7e
differential 2.79% <17.62%> (?)
total-cuda 18.05% <ø> (+<0.01%) ⬆️ Carriedforward from da67f7e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Motsu-san Motsu-san force-pushed the feat/road_surface_lidar_marker_extension branch from 35f03fd to a3a4921 Compare December 1, 2025 02:47
@Motsu-san Motsu-san force-pushed the feat/road_surface_lidar_marker_extension branch 2 times, most recently from 7bf6e24 to 3d82426 Compare January 29, 2026 04:44
@paulsohn
Copy link
Contributor

paulsohn commented Feb 6, 2026

@Motsu-san cc @KYabuuchi @TaikiYamada4 @YamatoAndo

As we decided to migrate tier4 launchers into autoware_launch repository,
a separate PR for tier4 launchers must be created unless this PR is merged before 2026/02/10 07:00 UTC (16:00 JST)

@Motsu-san Motsu-san force-pushed the feat/road_surface_lidar_marker_extension branch from 3d82426 to b2efe4f Compare February 17, 2026 01:55
@github-actions github-actions bot removed the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 17, 2026
@Motsu-san
Copy link
Contributor Author

@paulsohn Thank you for your notice! The conflict has been resolved.

@Motsu-san Motsu-san force-pushed the feat/road_surface_lidar_marker_extension branch 2 times, most recently from 265b0e7 to 66c7011 Compare February 18, 2026 00:52
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
for using PointType in both PointXYZIRC and PointXYZIRADRT

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
- Add check to skip empty ring pointclouds in detect_landmarks
- Prevent unnecessary processing and possible errors when a ring has no points

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
- Enable generic processing for multiple point cloud types
- Prepare for future multi-LiDAR marker localization support

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Motsu-san and others added 18 commits February 18, 2026 10:53
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>

# Conflicts:
#	launch/tier4_localization_launch/launch/localization.launch.xml
#	launch/tier4_localization_launch/launch/pose_twist_estimator/lidar_marker_localizer.launch.xml
#	launch/tier4_localization_launch/launch/pose_twist_estimator/pose_twist_estimator.launch.xml
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
To indicate the contributor's affiliation

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
…ramework

Signed-off-by: Motsu-san <83898149+Motsu-san@users.noreply.github.com>
@Motsu-san Motsu-san force-pushed the feat/road_surface_lidar_marker_extension branch from 66c7011 to d9c9775 Compare February 18, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

2 participants