refactor(autoware_universe): use autoware_ament_auto_package in system packages#12263
Open
vish0012 wants to merge 2 commits intoautowarefoundation:mainfrom
Open
Conversation
vish0012
requested review from
TetsuKawa,
TomohitoAndo,
asa-naki,
ito-san,
kosuke55,
mkuri,
nishikawa-masaki,
sasakisasaki,
shmpwk,
soblin and
veqcc
as code owners
vish0012
requested review from
1222-takeshi,
isamu-takagi and
mitsudome-r
as code owners
github-actions
bot
added
the
component:system
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
vish0012
added
the
run:build-and-test-differential
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12263 +/- ##
==========================================
+ Coverage 18.48% 19.27% +0.78%
==========================================
Files 1858 1895 +37
Lines 129162 130790 +1628
Branches 45965 48428 +2463
==========================================
+ Hits 23872 25206 +1334
- Misses 85485 86814 +1329
+ Partials 19805 18770 -1035
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isamu-takagi
approved these changes
Mar 10, 2026
nishikawa-masaki
approved these changes
Mar 11, 2026
Contributor
nishikawa-masaki
left a comment
nishikawa-masaki
left a comment
There was a problem hiding this comment.
Looks Good To Me.
mitsudome-r
approved these changes
Mar 12, 2026
shmpwk
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
ament_auto_package()withautoware_ament_auto_package()for warned system packages inautoware_universethat emitted scoped header installation warnings during the clean build investigation.Updated packages:
autoware_bluetooth_monitorautoware_command_mode_deciderautoware_command_mode_switcherautoware_diagnostic_graph_aggregatorautoware_diagnostic_graph_utilsautoware_dummy_diag_publisherautoware_dummy_infrastructureautoware_duplicated_node_checkerautoware_mrm_comfortable_stop_operatorautoware_mrm_emergency_stop_operatorautoware_mrm_handlerautoware_system_monitorautoware_velodyne_monitorHow was this PR tested?
Tested with:
colcon build --base-paths ~/autoware_scoped_headers/autoware/src --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to \ autoware_dummy_diag_publisher \ autoware_duplicated_node_checker \ autoware_diagnostic_graph_utils \ autoware_diagnostic_graph_aggregator \ autoware_bluetooth_monitor \ autoware_mrm_comfortable_stop_operator \ autoware_mrm_emergency_stop_operator \ autoware_mrm_handler \ autoware_system_monitor \ autoware_velodyne_monitor \ autoware_command_mode_decider \ autoware_command_mode_switcher \ autoware_dummy_infrastructureThe target packages built successfully.
Notes for reviewers
This is part of the follow-up work after adding
USE_SCOPED_HEADER_INSTALL_DIRsupport toautoware_cmake.Effects on system behavior
No functional behavior change is intended. This updates the package macro to the Autoware wrapper for the scoped header migration work.