feat(mpc_lateral_controller) add integrator friendly parameters to mpc lateral control#12301
Conversation
Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Mohammad <alqudah.mohammad@tier4.jp>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12301 +/- ##
==========================================
+ Coverage 18.36% 18.91% +0.55%
==========================================
Files 1849 1851 +2
Lines 128005 128142 +137
Branches 45554 45587 +33
==========================================
+ Hits 23507 24238 +731
- Misses 85042 85143 +101
+ Partials 19456 18761 -695
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TaikiYamada4
left a comment
There was a problem hiding this comment.
@mkquda
I believe this PR clamps the update amount of the steer_offset_target between two executions of run() in the mpc_lateral_controller, which only limits the update amount between ctrl_period:=0.03 seconds. Therefore, the controller looks like trying to compensate the steering offset as usual even if the steering_offset_update is larger than expected.
Since this change is aimed to make safe control by preventing the effect of drastic changes of steering_offset_update, I think clamping the value in set_steering_offset makes more sense to me. What do you think?
Description
Add parameter to limit change in steering offset, and implement logic to apply change limit in mpc_lateral_controller
Related links
Parent Issue:
How was this PR tested?
PSIM
Notes for reviewers
requires autowarefoundation/autoware_launch#1792
Interface changes
ROS Parameter Changes
steering_offset.max_update_thdouble0.01Effects on system behavior
None.