feat(autoware_raw_vehicle_cmd_conveter): adopt cie#12322
feat(autoware_raw_vehicle_cmd_conveter): adopt cie#12322TetsuKawa wants to merge 8 commits intoautowarefoundation:mainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12322 +/- ##
==========================================
+ Coverage 18.54% 19.09% +0.55%
==========================================
Files 1850 1880 +30
Lines 128011 129084 +1073
Branches 45591 48036 +2445
==========================================
+ Hits 23736 24647 +911
- Misses 84599 85398 +799
+ Partials 19676 19039 -637
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adopts autoware_agnocast_wrapper for autoware_raw_vehicle_cmd_converter so the node can switch between the standard ROS 2 executor and CallbackIsolatedAgnocastExecutor (CIE) based on ENABLE_AGNOCAST.
Changes:
- Add
autoware_agnocast_wrapperdependency to the package manifest. - Update CMake to find/link
autoware_agnocast_wrapper, run wrapper setup, and register the component with explicit ROS2/Agnocast executor options.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vehicle/autoware_raw_vehicle_cmd_converter/package.xml | Adds the wrapper dependency needed to build/run with CIE support. |
| vehicle/autoware_raw_vehicle_cmd_converter/CMakeLists.txt | Integrates the wrapper into the build and swaps node registration to the wrapper macro with executor configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
762f069 to
0f95ca4
Compare
0f95ca4 to
22d5915
Compare
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Description
Apply
autoware_agnocast_wrapperto enableCallbackIsolatedAgnocastExecutor(CIE) for this package, as part of the effort to achieve middleware-transparent scheduling and optimize end-to-end response time across Autoware. By going throughautoware_agnocast_wrapper, CIE activation is controlled by theENABLE_AGNOCASTenvironment variable — when unset or0, the node runs with the standard ROS 2 executor as before; when set to1, it switches toCallbackIsolatedAgnocastExecutor.Changes
Related links
How was this PR tested?
Notes for reviewers
Please review the following aspects:
CMakeLists.txtand launch files in this package have been updated (no missed files).SingleThreadedExecutorInterface changes
None.
Effects on system behavior
When
ENABLE_AGNOCAST=0(default), there is no change in behavior at all — the node runs with the standard ROS 2 executor exactly as before.When
ENABLE_AGNOCAST=1, the executor switches toCallbackIsolatedAgnocastExecutor(CIE). Internally, CIE creates a dedicatedrclcpp::SingleThreadedExecutorfor each callback group, so the fundamental scheduling behavior within each group remains almost identical. The key difference is that, for nodes originally usingSingleThreadedExecutor, callback groups now run in parallel across separate threads, similar toMultiThreadedExecutor.