Skip to content

feat(shape_estimation): use CallbackIsolatedAgnocastExecutor for shape_estimation#12357

Open
Koichi98 wants to merge 3 commits intoautowarefoundation:mainfrom
Koichi98:feat/apply_cie_to_shape_estimation
Open

feat(shape_estimation): use CallbackIsolatedAgnocastExecutor for shape_estimation#12357
Koichi98 wants to merge 3 commits intoautowarefoundation:mainfrom
Koichi98:feat/apply_cie_to_shape_estimation

Conversation

@Koichi98
Copy link
Contributor

@Koichi98 Koichi98 commented Mar 19, 2026

Description

Use AgnocastOnlyCallbackIsolatedExecutor (CIE) for shape_estimation node, as part of the effort to achieve middleware-transparent scheduling and optimize end-to-end response time across Autoware. By going through autoware_agnocast_wrapper, CIE activation is controlled by the ENABLE_AGNOCAST environment variable — when unset or 0, the node runs with the standard ROS 2 executor as before; when set to 1, it switches to AgnocastOnlyCallbackIsolatedExecutor.

Changes

  • CMakeLists.txt: Set SingleThreadedExecutor explicitly for ROS_EXECUTOR and changed to AgnocastOnlyCallbackIsolatedExecutor for AGNOCAST_EXECUTOR option.

Related links

How was this PR tested?

Notes for reviewers

Please review the following aspects:

  • Verify that all relevant CMakeLists.txt for shape_estimation node have been updated (no missed files).

    • Our current target is X2 v4.4.0, so please let us know if we have applied CIE to any nodes that do not run with that version.
  • If the node meets all of the following conditions, please check for potential race conditions (see Effects on system behavior for the reason):

    1. The node was originally running on a rclcpp::executors::SingleThreadedExecutor or rclcpp_components::component_container
    2. The node has multiple callback groups (the default is one)
    3. Shared variables are accessed across callback groups without proper mutex protection

    Note: Nodes already running on MultiThreadedExecutor (or component_container_mt) are not affected, as their callbacks are already executed concurrently.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 19, 2026
@github-actions
Copy link

github-actions bot commented Mar 19, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Koichi98 Koichi98 marked this pull request as draft March 19, 2026 01:20
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
@Koichi98 Koichi98 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 19, 2026
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.07%. Comparing base (54657b7) to head (f2e1993).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12357      +/-   ##
==========================================
+ Coverage   18.54%   19.07%   +0.52%     
==========================================
  Files        1850     1880      +30     
  Lines      128011   129108    +1097     
  Branches    45591    47930    +2339     
==========================================
+ Hits        23736    24623     +887     
- Misses      84599    85444     +845     
+ Partials    19676    19041     -635     
Flag Coverage Δ *Carryforward flag
daily 21.01% <ø> (+<0.01%) ⬆️ Carriedforward from d07e3a3
daily-cuda 18.53% <ø> (+<0.01%) ⬆️ Carriedforward from d07e3a3
differential 2.72% <ø> (?)
differential-cuda 12.39% <ø> (?)
total-cuda 18.53% <ø> (+<0.01%) ⬆️ Carriedforward from d07e3a3
total-humble-cuda 18.53% <ø> (+<0.01%) ⬆️ Carriedforward from d07e3a3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant