feat(voxel_grid_based_euclidean_cluster): use CallbackIsolatedAgnocastExecutor for voxel_grid_based_euclidean_cluster#12361
Open
Koichi98 wants to merge 5 commits intoautowarefoundation:mainfrom
Conversation
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
51 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12361 +/- ##
==========================================
+ Coverage 18.54% 19.03% +0.49%
==========================================
Files 1850 1880 +30
Lines 128011 129149 +1138
Branches 45591 47993 +2402
==========================================
+ Hits 23736 24581 +845
- Misses 84599 85482 +883
+ Partials 19676 19086 -590
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
CallbackIsolatedAgnocastExecutor(CIE) forvoxel_grid_based_euclidean_clusternode, as part of the effort to achieve middleware-transparent scheduling and optimize end-to-end response time across Autoware. By going throughautoware_agnocast_wrapper, CIE activation is controlled by theENABLE_AGNOCASTenvironment variable — when unset or0, the node runs with the standard ROS 2 executor as before; when set to1, it switches toCallbackIsolatedAgnocastExecutor.Changes
CMakeLists.txt: Set
SingleThreadedExecutorexplicitly forROS_EXECUTORand changed toCallbackIsolatedAgnocastExecutorforAGNOCAST_EXECUTORoption.voxel_grid_based_euclidean_cluster.launch.xml: Pass
use_multithread=truetoagnocast_env.launch.xmlso thatagnocast_component_container_cieis used whenENABLE_AGNOCAST=1. Also passcontainer_packageandcontainer_executableto the Python launch file.voxel_grid_based_euclidean_cluster.launch.xml: Pass
container_packageandcontainer_executableto the Python launch file. -Related links
Parent Issue: Apply CallbackIsolatedAgnocastExecutor (CIE) to safety-/performance-critical nodes autoware_core#968
AutowareDiscussion about adopting CIE
What is autoware_agnocast_wrapper?
How was this PR tested?
Notes for reviewers
Please review the following aspects:
Verify that all relevant
CMakeLists.txtforvoxel_grid_based_euclidean_clusternode have been updated (no missed files).If the node meets all of the following conditions, please check for potential race conditions (see Effects on system behavior for the reason):
rclcpp::executors::SingleThreadedExecutororrclcpp_components::component_containerInterface changes
None.
Effects on system behavior
When
ENABLE_AGNOCAST=0(default), there is no change in behavior at all — the node runs with the standard ROS 2 executor exactly as before.When
ENABLE_AGNOCAST=1, the executor switches toCallbackIsolatedAgnocastExecutor(CIE). Internally, CIE creates a dedicatedrclcpp::executors::SingleThreadedExecutorfor each callback group, so the fundamental scheduling behavior within each group remains almost identical. The key difference is that, for nodes originally usingrclcpp::executors::SingleThreadedExecutor, callback groups now run in parallel across separate threads, similar toMultiThreadedExecutor.