fix(autoware_tensorrt_plugins): avoid tv::zeros and tv::empty#12378
fix(autoware_tensorrt_plugins): avoid tv::zeros and tv::empty#12378veqcc merged 17 commits intoautowarefoundation:mainfrom
Conversation
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12378 +/- ##
===========================================
- Coverage 18.73% 0.00% -18.74%
===========================================
Files 1904 96 -1808
Lines 129969 3497 -126472
Branches 43951 0 -43951
===========================================
- Hits 24355 0 -24355
+ Misses 85621 3497 -82124
+ Partials 19993 0 -19993
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perception/autoware_tensorrt_plugins/src/get_indices_pairs_implicit_gemm_plugin.cpp
Show resolved
Hide resolved
perception/autoware_tensorrt_plugins/src/get_indices_pairs_implicit_gemm_plugin.cpp
Show resolved
Hide resolved
perception/autoware_tensorrt_plugins/src/get_indices_pairs_implicit_gemm_plugin.cpp
Outdated
Show resolved
Hide resolved
perception/autoware_tensorrt_plugins/src/get_indices_pairs_implicit_gemm_plugin.cpp
Outdated
Show resolved
Hide resolved
perception/autoware_tensorrt_plugins/src/get_indices_pairs_implicit_gemm_plugin.cpp
Show resolved
Hide resolved
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
|
@amadeuszsz |
|
@veqcc |
I have tested the following on x86-64 machine
|
|
@amadeuszsz |
KSeangTan
left a comment
There was a problem hiding this comment.
LGTM overall, please address comments accordingly
Description
This PR removes
tv::zerosandtv::empty.This is because they call
cudaMallocinside tensorview, which leads to engine build error on NVIDIA DRIVE AGX Thor.implicit_gemm_plugin.cpp, thetv::zeroscall is just moved to the constructorget_indices_pairs_implicit_gemm_plugin.cpp, it is a little bit complextv::zerosandtv::emptytv::from_blobinstead of them at runtimeRelated links
Parent Issue:
How was this PR tested?
I have checked compile/engine-build/execution worked well on both x86-64 machine and DRIVE Thor.
Through TIER IV internal evaluator, there is no regression on inference precision.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.