fix(autoware_tensorrt_yolox): add missing cstdint include and ament_index_cpp test dependency#12400
Merged
xmfcx merged 1 commit intoautowarefoundation:mainfrom Mar 31, 2026
Conversation
…ndex_cpp test dependency label.hpp uses uint32_t without including <cstdint>, causing build failure on Ubuntu 24.04 / ROS 2 Jazzy. test_label.cpp uses ament_index_cpp but it was not declared as a test dependency. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
xmfcx
requested review from
MasatoSaeki,
dan-dnn,
ktro2828 and
manato
as code owners
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
xmfcx
added
the
run:build-and-test-differential
mitsudome-r
approved these changes
Mar 31, 2026
github-project-automation
bot
moved this from To Triage
to Done
in Software Working Group
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12400 +/- ##
==========================================
+ Coverage 18.48% 18.88% +0.40%
==========================================
Files 1858 1897 +39
Lines 129162 130891 +1729
Branches 45965 48378 +2413
==========================================
+ Hits 23872 24719 +847
- Misses 85485 86936 +1451
+ Partials 19805 19236 -569
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PanConChicharron
pushed a commit
to PanConChicharron/autoware.universe
that referenced
this pull request
Apr 6, 2026
…ndex_cpp test dependency (autowarefoundation#12400) label.hpp uses uint32_t without including <cstdint>, causing build failure on Ubuntu 24.04 / ROS 2 Jazzy. test_label.cpp uses ament_index_cpp but it was not declared as a test dependency. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#include <cstdint>tolabel.hppforuint32_t<test_depend>ament_index_cpp</test_depend>topackage.xmlfortest_label.cppWhy
autoware_tensorrt_yoloxfails to compile on Ubuntu 24.04 / ROS 2 Jazzy becauselabel.hppusesuint32_twithout including<cstdint>, and the test depends onament_index_cppwhich is not declared inpackage.xml.Test plan
colcon build --packages-select autoware_tensorrt_yoloxcompiles without errors