feat(trajectory_validator): add evaluation tables to propagate filtering results#12445
Draft
zulfaqar-azmi-t4 wants to merge 1 commit intoautowarefoundation:mainfrom
Draft
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
c48705a to
b573816
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current
trajectory_validatorsimply filters trajectories based on plugin results but does not provide a structured mechanism to store or query the specific reasons for failure per plugin. This PR introduces an internalEvaluationTableto capture granular evaluation data during the validation process.Key Changes:
PluginEvaluationandEvaluationTablestructs to store the feasibility status and error reasons for each plugin, mapped by the trajectory's generator ID.categoryfield to theValidatorInterfaceto allow plugins to be grouped (e.g., by functionality or source).evaluation_tables_vector. For every trajectory processed, the validator now records:update_diagnosticto accept both input and filtered trajectories. This enables more accurate diagnostic reporting by comparing what was received against what survived validation, preventing false alarms when input data is missing.List of Technical Changes
1. Data Structure Definitions (
trajectory_validator_node.hpp)PluginEvaluation: A new struct containingplugin_name,is_feasible, andreason.EvaluationTable: A new struct containinggenerator_id,is_overall_feasible, and anunordered_mapof evaluations indexed by plugin category.evaluation_tables_as a member variable to theTrajectoryValidatorclass.2. Interface Enhancements (
validator_interface.hpp)set_category()andcategory()methods to theValidatorInterfaceclass.category_string member to store the plugin's functional group.3. Processing Logic (
trajectory_validator_node.cpp)processfunction now clears theevaluation_tables_at the start of each cycle.PluginEvaluationobject for every plugin/trajectory pair.!res(infeasible), the specific error string is captured inevaluation.reasonand theoverall_feasibleflag for that trajectory is set tofalse.::delimiter) and assigns it viaset_category.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.