feat(dummy_traffic_light_publisher): add new node to publish traffic light message instead of Rviz#12456
Open
takam5f2 wants to merge 14 commits intoautowarefoundation:mainfrom
Open
Conversation
…simulator Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
…ation Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
…_universe into feat/add-dummy_traffic_light_publisher
Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
…_universe into feat/add-dummy_traffic_light_publisher
Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
Signed-off-by: Takayuki AKAMINE <takayuki.akamine@tier4.jp>
Contributor
Author
|
@sasakisasaki |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
autoware_dummy_traffic_light_publisher— a dedicated simulator node that publishes dummy traffic light signals for Planning Simulator environments where the traffic light recognition pipeline is not available.Background
In the current Planning Simulator workflow, traffic light signals are injected via the
tier4_traffic_light_rviz_plugin(TrafficLightPublishPanel), which publishes directly to/perception/traffic_light_recognition/traffic_signals. This procedure is documented in the official Autoware documentation:However, an RViz plugin — a GUI visualization tool — should not publish messages directly to topics that the autonomous driving system consumes as sensor/perception input. This creates an implicit and undesirable dependency between the visualization layer and the AD control logic.
This PR introduces a simulator node (
autoware_dummy_traffic_light_publisher) that sits between external inputs (e.g., the RViz plugin) and the AD system, so that the plugin no longer needs to publish directly to a perception topic.Features
TrafficLightGroupArray(no signal information)Architecture
DummyTrafficLightPublisherNodetake()), timer, publisher, vector map parsingDummyTrafficLightTrafficLightGroupArrayconstructionTrafficLightCycleTrafficLightElementoutputRelated links
Parent Issue:
Relevant documentation (current behavior to be updated):
How was this PR tested?
Unit tests for
TrafficLightCycle(14 tests) andDummyTrafficLight(14 tests) — all passCode coverage:
traffic_light_cycle.cpp100%,dummy_traffic_light.cpp95% (uncovered lines are closing braces only)Verified with Planning Simulator (standalone mode):
Ego vehicle passes the intersection on green signal after stopping on red signal:
Ego vehicle is not engaged and traffic lights state changes time by time.
Notes for reviewers
subscription->take()in the timer callback instead of subscription callbacksautoware_launchintegration (adding tosimulator.launch.xml) and RViz plugin topic redirection will be handled in separate PRsInterface changes
Topic changes
Additions and removals
~/input/vector_mapautoware_map_msgs/msg/LaneletMapBin~/input/traffic_signalsautoware_perception_msgs/msg/TrafficLightGroupArray~/output/traffic_signalsautoware_perception_msgs/msg/TrafficLightGroupArrayModifications
None.
ROS Parameter Changes
Additions and removals
modestring"empty""standalone"or"empty"publish_ratedouble10.0green_durationdouble30.0yellow_durationdouble3.0red_durationdouble30.0passthrough_timeoutdouble1.0Modifications
None.
Effects on system behavior
None. This is a new standalone package with no integration into existing launch files yet.